Skip to content

Commit eaa0792

Browse files
authored
Fix subscriptionIds for no network deployment scenario (#1574)
1 parent 9ead68e commit eaa0792

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

docs/wiki/Whats-new.md

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ Here's what's changed in Enterprise Scale/Azure Landing Zones:
4747
- Changed enforcementMode of the assignment of Policy "Deploy-UserAssignedManagedIdentity-VMInsights" to Default. This is to ensure that a Resource Group and a User Assigned Managed Identity are created on new subscriptions (subscriptions that are added after the initial deployment).
4848
- Bug fix for Portal Accelerator. userAssignedIdentityResourceGroup has been added as output for the Portal UI, this fixes deploying the Resource Group with a custom name.
4949
- Bug fix for Portal Accelerator. `subscriptionIds` now uses lambda function to obtain the subscription IDs from `corpConnectedLzSubscriptionId`. This fixes the Invalid Template error when selecting a corp connected landing zone deployment.
50+
- Bug fix for Portal Accelerator. `connectivitySubscriptionId` is now skipped when no networking components are deployed. This fixes an InvalidTemplateDeployment error deploying the Resource Group for UAMI.
5051

5152
### AMA Update for the Portal Accelerator
5253

eslzArm/eslzArm.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1209,7 +1209,7 @@
12091209
},
12101210
"privateDnsZonesMerge": "[if(and(contains(variables('azBackupGeoCodes'), parameters('connectivityLocation')), contains(variables('privateDnsZones'), 'privatelink.regionGeoShortCode.backup.windowsazure.com')), union(createArray(replace(variables('privateDnsZones')[0], '.regionGeoShortCode.', concat('.', variables('azBackupGeoCodes')[toLower(parameters('connectivityLocation'))], '.'))), variables('privateDnsZones')), variables('privateDnsZones'))]",
12111211
"privateDnsZonesMergedWithBackupPlaceholderRemoved": "[filter(variables('privateDnsZonesMerge'), lambda('i', not(equals(lambdaVariables('i'), 'privatelink.regionGeoShortCode.backup.windowsazure.com'))))]",
1212-
"subscriptionIds": "[union(parameters('onlineLzSubscriptionId'), parameters('corpLzSubscriptionId'), map(parameters('corpConnectedLzSubscriptionId'), lambda('sub', lambdaVariables('sub').subs)), if(empty(parameters('singlePlatformSubscriptionId')), createArray(parameters('managementSubscriptionId'), parameters('connectivitySubscriptionId'), parameters('identitySubscriptionId')), createArray(parameters('singlePlatformSubscriptionId'))))]",
1212+
"subscriptionIds": "[union(parameters('onlineLzSubscriptionId'), parameters('corpLzSubscriptionId'), map(parameters('corpConnectedLzSubscriptionId'), lambda('sub', lambdaVariables('sub').subs)), if(empty(parameters('singlePlatformSubscriptionId')), if(empty(parameters('connectivitySubscriptionId')), createArray(parameters('managementSubscriptionId'), parameters('identitySubscriptionId')), createArray(parameters('managementSubscriptionId'), parameters('connectivitySubscriptionId'), parameters('identitySubscriptionId'))), createArray(parameters('singlePlatformSubscriptionId'))))]",
12131213
"roleDefinitions": {
12141214
"networkContributor": "4d97b98b-1d4f-4787-a291-c67834d212e7"
12151215
},

eslzArm/managementGroupTemplates/policyDefinitions/policies.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"metadata": {
55
"_generator": {
66
"name": "bicep",
7-
"version": "0.24.24.22086",
8-
"templateHash": "3120908925847435197"
7+
"version": "0.25.3.34343",
8+
"templateHash": "3652133731970980584"
99
}
1010
},
1111
"parameters": {

eslzArm/managementGroupTemplates/roleDefinitions/customRoleDefinitions.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"metadata": {
55
"_generator": {
66
"name": "bicep",
7-
"version": "0.24.24.22086",
8-
"templateHash": "7374068324501208275"
7+
"version": "0.25.3.34343",
8+
"templateHash": "1651684598162821371"
99
}
1010
},
1111
"variables": {

0 commit comments

Comments
 (0)