Fixed number of accessibility issues. Fixed bug with creating a new page. (#145)

Author: azaslonov

package-lock.json

@@ -61,11 +61,11 @@
         "webpack-merge": "^4.2.1"
     },
     "dependencies": {
-        "@paperbits/azure": "0.1.145",
-        "@paperbits/common": "0.1.145",
-        "@paperbits/core": "0.1.145",
-        "@paperbits/prosemirror": "0.1.145",
-        "@paperbits/styles": "0.1.145",
+        "@paperbits/azure": "0.1.146",
+        "@paperbits/common": "0.1.146",
+        "@paperbits/core": "0.1.146",
+        "@paperbits/prosemirror": "0.1.146",
+        "@paperbits/styles": "0.1.146",
         "@webcomponents/webcomponentsjs": "^2.2.10",
         "core-js": "^3.1.4",
         "domino": "^2.1.3",

package.json

@@ -13,37 +13,42 @@ export class UnsavedChangesRouteGuard implements RouteGuard {
 
     public canActivate(route: Route): Promise<boolean> {
         return new Promise<boolean>(async (resolve) => {
-            if (this.offlineObjectStorage.hasUnsavedChanges()) {
-                const path = route.path;
-
-                if (route.previous && route.previous.path === path) {
-                    const page = await this.pageService.getPageByPermalink(path);
-
-                    if (page && this.offlineObjectStorage.hasUnsavedChangesAt(page.contentKey)) {
-                        const toast = this.viewManager.addToast("Unsaved changes", `You have unsaved changes. Do you want to save or discard them?`, [
-                            {
-                                title: "Save",
-                                iconClass: "paperbits-check-2",
-                                action: async (): Promise<void> => {
-                                    this.offlineObjectStorage.saveChanges();
-                                    this.viewManager.removeToast(toast);
-                                    resolve(true);
-                                }
-                            },
-                            {
-                                title: "Discard",
-                                iconClass: "paperbits-simple-remove",
-                                action: async (): Promise<void> => {
-                                    this.offlineObjectStorage.discardChanges();
-                                    this.viewManager.removeToast(toast);
-                                    resolve(true);
-                                }
+            if (!this.offlineObjectStorage.hasUnsavedChanges()) {
+                resolve(true);
+            }
+
+            const path = route.path;
+
+            const pathNotChanged = route.previous && route.previous.path === path;
+
+            if (pathNotChanged) {
+                const page = await this.pageService.getPageByPermalink(path);
+
+                if (!page || !page.contentKey) {
+                    resolve(true);
+                }
+
+                if (this.offlineObjectStorage.hasUnsavedChangesAt(page.contentKey)) {
+                    const toast = this.viewManager.addToast("Unsaved changes", `You have unsaved changes. Do you want to save or discard them?`, [
+                        {
+                            title: "Save",
+                            iconClass: "paperbits-check-2",
+                            action: async (): Promise<void> => {
+                                await this.offlineObjectStorage.saveChanges();
+                                this.viewManager.removeToast(toast);
+                                resolve(true);
+                            }
+                        },
+                        {
+                            title: "Discard",
+                            iconClass: "paperbits-simple-remove",
+                            action: async (): Promise<void> => {
+                                await this.offlineObjectStorage.discardChanges();
+                                this.viewManager.removeToast(toast);
+                                resolve(true);
                             }
-                        ]);
-                    }
-                    else {
-                        resolve(true);
-                    }
+                        }
+                    ]);
                 }
             }
             else {

src/routing/unsavedChangesRouteGuard.ts

@@ -10,7 +10,6 @@ $tip-width: 10px;
     z-index: $z-index-balloon;
     box-shadow: 0 0 2px 2px rgba(0, 0, 0, .15);
     border-radius: $toolbox-border-radius;
-    line-height: $surface-lineheight;
     display: block;
 
     &:after {

src/themes/designer/styles/balloons.scss

@@ -24,7 +24,7 @@
 
 .placeholder {
     border: 2px dashed #ccc;
-    border: 2px dashed darken($surface-background, 20%);
+    border: 2px dashed darken($toolbox-background, 20%);
     transition: height .5s ease-in-out;
     position: relative;
 }

src/themes/designer/styles/draggables.scss

@@ -9,6 +9,7 @@
     display: block;
     position: relative;
     text-align: center;
+    line-height: 30px;
 }
 
 .palette {