Merge pull request #664 from Azure/ewertons/FixDestroy

ewertons · web-flow · commit 51d6f3f72468 · 2024-05-20T18:45:48.000-07:00
Indicate error in tlsio schannel if list operation fails
diff --git a/adapters/tlsio_schannel.c b/adapters/tlsio_schannel.c
@@ -1242,6 +1242,8 @@ void tlsio_schannel_destroy(CONCRETE_IO_HANDLE tls_io)
                 if (singlylinkedlist_remove(tls_io_instance->pending_io_list, first_pending_io) != 0)
                 {
                     LogError("Failure: removing pending IO from list");
+                    indicate_error(tls_io_instance);
+                    break;
                 }
 
                 first_pending_io = singlylinkedlist_get_head_item(tls_io_instance->pending_io_list);

Original file line number	Diff line number	Diff line change
`@@ -1242,6 +1242,8 @@ void tlsio_schannel_destroy(CONCRETE_IO_HANDLE tls_io)`
`1242`	`1242`	`if (singlylinkedlist_remove(tls_io_instance->pending_io_list, first_pending_io) != 0)`
`1243`	`1243`	`{`
`1244`	`1244`	`LogError("Failure: removing pending IO from list");`
	`1245`	`+ indicate_error(tls_io_instance);`
	`1246`	`+ break;`
`1245`	`1247`	`}`
`1246`	`1248`
`1247`	`1249`	`first_pending_io = singlylinkedlist_get_head_item(tls_io_instance->pending_io_list);`