Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Plug and Play Command request informational fields do not change color in dark mode #638

Open
domasgim opened this issue Sep 4, 2023 · 1 comment
Labels
bug Something isn't working needs review Review required by team member

Comments

@domasgim
Copy link

domasgim commented Sep 4, 2023

Describe the bug
Command tab does not display Command request schema (name, displayName and other parameters), just a blank field to enter information

An older IoT Explorer 15.2 version did not have this bug. The application was updated with the following commands

apt remove azure-iot-explorer
apt install ./azure-iot-explorer_0.15.9_amd64.deb

15.2 version was later installed back and the issue was resolved

To Reproduce
Steps to reproduce the behavior:

  1. Define a PnP interface which contains a Command with request schema
{
  "@context": "dtmi:dtdl:context;2",
  "@id": "dtmi:XXX:ipBlockInterface;1",
  "@type": "Interface",
  "displayName": "XXXIpBlockInterface",
  "contents": [
    {
      "@type": "Command",
      "name": "ip_block_push",
      "displayName": "Push to IP Block",
      "request": {
        "name": "request",
        "displayName": "Request",
        "schema": {
          "@type": "Object",
          "fields": [
            {
              "name": "ip",
              "displayName": "IP address",
              "schema": "string"
            },
            {
              "name": "destination_ip",
              "displayName": "Destination IP address",
              "schema": "string"
            },
            {
              "name": "port",
              "displayName": "Port address",
              "schema": "string"
            },
            {
              "name": "proto",
              "displayName": "Protocol",
              "schema": "string"
            }
          ]
        }
      }
    }
  ]
}

  1. Check IoT Plug and Play component Commands tab
  2. See error (no command request name, display name rendered)

Expected behavior
Command request name, display name and other information should be shown. In this particular example the first field should show Destination IP address, the second field Port address

Screenshots
Screenshot from 2023-09-04 13-18-13

Screenshot from 2023-09-04 13-19-46

Screenshot from 2023-09-04 13-20-32

Version 15.2 without the bug
Screenshot from 2023-09-04 13-29-58

Desktop (please complete the following information):

  • Ubuntu
  • 22.04.2 LTS
  • azure-iot-explorer_0.15.9_amd64.deb and azure-iot-explorer_0.15.8_amd64.deb
@domasgim domasgim added bug Something isn't working needs review Review required by team member labels Sep 4, 2023
@domasgim domasgim changed the title [BUG] Plug and Play Command request fields not rendered [BUG] Plug and Play Command request informational fields not rendered Sep 4, 2023
@domasgim
Copy link
Author

Found the issue... using dark mode these fields do get their colors updated

@domasgim domasgim changed the title [BUG] Plug and Play Command request informational fields not rendered [BUG] Plug and Play Command request informational fields do not change color in dark mode Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs review Review required by team member
Projects
None yet
Development

No branches or pull requests

1 participant