Skip to content

Commit

Permalink
Addressing APIView comments for JAVA (#31385)
Browse files Browse the repository at this point in the history
* Renamed a few models for Java SDK

* Using ErrorResponse from Azure.core.foundations over the customized TranslationError object

* Fixing the DocumentStatus name

* Updating ErrorResponse to Error

* Another update from ErrorResponse to Error

* Updating generateMetadata to true for typespec-ts

* Fixing the openapi

* Reverting the use of Azure.core.Foundation.Error object

* Reverting TranslationErrorResponse model

* Just fixing the order of model definitions

* Another fix in model
  • Loading branch information
hamshavathimunibyraiah authored Nov 7, 2024
1 parent 901bdbf commit 0409069
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,16 @@ interface SingleDocumentTranslationClient {
"csharp, java"
);

@@clientName(DocumentTranslation.SourceInput,
"TranslationSource",
"csharp, java"
);

@@clientName(DocumentTranslation.TargetInput,
"TranslationTarget",
"csharp, java"
);

@@clientName(DocumentTranslation.BatchRequest, "documentBatch", "python");

@@convenientAPI(DocumentTranslationClient.getSupportedFormats, false, "java");
Expand Down Expand Up @@ -111,7 +121,10 @@ interface SingleDocumentTranslationClient {

@@clientName(DocumentTranslation.Glossary.version, "format_version", "python");

@@clientName(DocumentTranslation.Glossary, "TranslationGlossary", "python");
@@clientName(DocumentTranslation.Glossary,
"TranslationGlossary",
"python, java"
);

@@clientName(DocumentTranslation.DocumentStatus.createdDateTimeUtc,
"created_on",
Expand Down Expand Up @@ -204,6 +217,11 @@ interface SingleDocumentTranslationClient {
"java"
);

@@clientName(DocumentTranslation.DocumentStatus,
"documentStatusResult",
"java"
);

@@clientName(DocumentTranslation.Status, "translationStatus", "java");

@@clientName(DocumentTranslation.TranslationStatus.createdDateTimeUtc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ options:
generate-sample-project: false
"@azure-tools/typespec-ts":
package-dir: "ai-translation-document-rest"
generateMetadata: false
generateMetadata: true
generateTest: false
packageDetails:
name: "@azure-rest/ai-translation-document"
Expand Down

0 comments on commit 0409069

Please sign in to comment.