Skip to content

Commit 86d7ec0

Browse files
Copilotminhanh-phan
andcommitted
Move remaining skip-related comments outside test functions for consistency
Co-authored-by: minhanh-phan <[email protected]>
1 parent e522015 commit 86d7ec0

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

sdk/identity/identity/test/public/node/deviceCodeCredential.spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,11 @@ describe("DeviceCodeCredential", function () {
9292
},
9393
);
9494

95+
// Because of the user interaction, this test works inconsistently in our live test pipelines.
96+
// On playback we can't quite control the time needed to trigger this error.
9597
it.skipIf(isLiveMode() || isPlaybackMode())(
9698
"allows cancelling the authentication",
9799
async function () {
98-
// Because of the user interaction, this test works inconsistently in our live test pipelines.
99-
// On playback we can't quite control the time needed to trigger this error.
100-
101100
const credential = new DeviceCodeCredential(
102101
recorder.configureClientOptions({
103102
tenantId: env.AZURE_TENANT_ID,

sdk/identity/identity/test/public/node/environmentCredential.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,10 @@ describe.skipIf(shouldRunSPTest())("EnvironmentCredential", function () {
8484
},
8585
);
8686

87+
// Live test run not supported on CI at the moment. Locally should work though.
8788
it.skipIf(isLiveMode())(
8889
"authenticates with a client certificate and password on the environment variables",
8990
async function () {
90-
// Live test run not supported on CI at the moment. Locally should work though.
9191
// The following environment variables must be set for this to work.
9292
// On TEST_MODE="playback", the recorder automatically fills them with stubbed values.
9393
process.env.AZURE_TENANT_ID = cachedValues.AZURE_TENANT_ID;

0 commit comments

Comments
 (0)