Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency package @typescript-eslint/parser has a new version available #22700

Open
azure-sdk opened this issue Jul 25, 2022 · 2 comments
Open
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required EngSys This issue is impacting the engineering system.

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 25, 2022

We have identified a dependency on version 8.16.0 of @typescript-eslint/parser. A new version (8.21.0) is available for upgrade.

Following are the steps to upgrade package dependency.

  1. Understand the breaking changes between the version being used and the version you want to upgrade to.

  2. Identify all packages that take a dependency on this package.

  3. Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

  4. Run rush update to ensure the new version is pulled in.

  5. Make relevant changes to absorb the breaking changes.

  6. Repeat steps 3 to 5 for each of the packages that have a dependency on this package.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 25, 2022
@azure-sdk
Copy link
Collaborator Author

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.3230474,Service Bus:0.18756206,EngSys:0.045930713'

@xirzec xirzec added the Client This issue points to a problem in the data-plane of the library. label Jul 25, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 25, 2022
@jeremymeng jeremymeng added the EngSys This issue is impacting the engineering system. label Sep 12, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Feb 20, 2023
Change batch to use package-2021-06-03-preview-only (Azure#22700)

* Change batch to use package-2021-06-03-preview-only

* Readd other batch packages

Also add tag block for package-2021-06-03-preview

* update

* Update readme.python.md

---------

Co-authored-by: msyyc <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
@jeremymeng
Copy link
Member

Need node16+ now typescript-eslint/typescript-eslint#7284

xirzec added a commit that referenced this issue Apr 30, 2024
### Packages impacted by this PR

`@azure/eslint-plugin-azure-sdk`

### Issues associated with this PR

#22698
#22699
#22700
#22701

### Describe the problem that is addressed by this PR

This moves us from v5 -> v6 of eslint-typescript dependencies. The
current stable is 7 with 8 in early alpha. Since major changes include
breaks, it was easier to do this migration one major version at a time,
hence starting with the upgrade to 6. I am hopeful that 6 -> 7 will be
less messy, but I make no promises.

The major annoyance I ran into is you have to create mock "fixtures"
(dummy files) for any test asset paths (e.g. you tell the linter you are
testing `foo/bar/baz.ts` you need a tsconfig somewhere with that file
listed as included *and* you need that exact directory/file structure on
disk somewhere. eslint-typescript blames typescript for this limitation,
but I'm not familiar enough with the parser APIs to know if they're
correct in their analysis.

Note: I haven't gone through to audit all the rules yet, as some are
still a bit busted or need to be removed, but for the sake of updating
our dependencies, I moved everything forward as-is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

3 participants