Dependency package @typescript-eslint/typescript-estree has a new version available #22701
Assignees
Labels
Client
This issue points to a problem in the data-plane of the library.
dependency-upgrade-required
EngSys
This issue is impacting the engineering system.
Comments
ghost
added
the
needs-triage
|
Label prediction was below confidence level |
xirzec
added
the
Client
ghost
removed
the
needs-triage
|
The problem with the linter packages is that they could have breaking changes between minor versions, which could be annoying to fix in automatic rush update --full PRs. Perhaps we could relax this upgrade requirement for linter packages? it is not super important to stay on latest and they shouldn't cause security vulnerabilities AFAICT. /cc @jeremymeng @xirzec |
|
yeah, I am thinking about just parking these work items as lower priority and upgrade @typescript-eslint dependencies less frequently. |
xirzec
added a commit
that referenced
this issue
Apr 30, 2024
### Packages impacted by this PR `@azure/eslint-plugin-azure-sdk` ### Issues associated with this PR #22698 #22699 #22700 #22701 ### Describe the problem that is addressed by this PR This moves us from v5 -> v6 of eslint-typescript dependencies. The current stable is 7 with 8 in early alpha. Since major changes include breaks, it was easier to do this migration one major version at a time, hence starting with the upgrade to 6. I am hopeful that 6 -> 7 will be less messy, but I make no promises. The major annoyance I ran into is you have to create mock "fixtures" (dummy files) for any test asset paths (e.g. you tell the linter you are testing `foo/bar/baz.ts` you need a tsconfig somewhere with that file listed as included *and* you need that exact directory/file structure on disk somewhere. eslint-typescript blames typescript for this limitation, but I'm not familiar enough with the parser APIs to know if they're correct in their analysis. Note: I haven't gone through to audit all the rules yet, as some are still a bit busted or need to be removed, but for the sake of updating our dependencies, I moved everything forward as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have identified a dependency on version 8.16.0 of @typescript-eslint/typescript-estree. A new version (8.20.0) is available for upgrade.
Following are the steps to upgrade package dependency.
Understand the breaking changes between the version being used and the version you want to upgrade to.
Identify all packages that take a dependency on this package.
Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.
Run rush update to ensure the new version is pulled in.
Make relevant changes to absorb the breaking changes.
Repeat steps 3 to 5 for each of the packages that have a dependency on this package.
The text was updated successfully, but these errors were encountered: