[Core] Resolve Azure.Core AOT warnings impacting the AOT compatibility of Azure.Monitor.OpenTelemetry.Exporter

[m-redding]

Library name

Azure.Core

Please describe the feature.

This issue is tracking the work needed to resolve #35572

• Upgrade System.Diagnostics.DiagnosticSource to 6.0.1
  • [Event Grid] [Event Hubs] [Service Bus] [Storage] Adding ActivitySource and migrating all DiagnosticScope.ActivityKind references #37600
  • [EventGrid] Moving from ActivityExtensions to System.Diagnostics.DiagnosticSource #37597
  • [Core] Upgrading dependency on System.Diagnostics.DiagnosticSource #37418
• Remove reflection code for all non netcoreapp2.1 targets
  • [Core] Updating System.Diagnostics.DiagnosticSource types usage #37661
• Disable tracing for netcoreapp2.1 and remove reflection code entirely
  • [Core] Disable otel tracing in netcoreapp2.1 #37763
• Add attributes to various classes to resolve warnings
  • [Core] Adding attributes to support Native AOT compiling #37734
• Consider moving RequestFailedException to use source generation for deserialization.
• [Core] DiagnosticSource.Write needs type to work with trimming #37733 - adding this work to the PR
• Investigate how to resolve warnings from DynamicData.Equals() and MutableJsonElement.ToString(). They cannot have the "RequiresUnreferencedCode" attribute because the attribute must exist on the method being overridden
  • Marked relevant classes as RequiresUnreferencedCode
  • Opened issue since RequiresUnreferencedCode cannot be applied to structs - currently no workaround
• [Core] Consider removing reflection code from HttpPipelineSynchronousPolicy #38225
• [Core] Add CI pipeline to test for AOT compatibility #38226

[JeyJeyGao]

Hello @m-redding , looks like there is still a trim warning for Azure.Core when build with AOT enabled.

Warnings:

/home/jj/.nuget/packages/azure.core/1.36.0/lib/net6.0/Azure.Core.dll : warning IL2104: Assembly 'Azure.Core' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/home/jj/projects/junjie/notation-azure-kv/Notation.Plugin.AzureKeyVault/Notation.Plugin.AzureKeyVault.csproj]
/home/jj/.nuget/packages/azure.security.keyvault.keys/4.6.0-beta.2/lib/netstandard2.0/Azure.Security.KeyVault.Keys.dll : warning IL2104: Assembly 'Azure.Security.KeyVault.Keys' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/home/jj/projects/junjie/notation-azure-kv/Notation.Plugin.AzureKeyVault/Notation.Plugin.AzureKeyVault.csproj]

Could you tell me how to fix it? Dotnet 8 stable version was released and we are going to bump up to Dotnet 8 with AOT enabled.

[m-redding]

Hey @JeyJeyGao I have been looking into this and I can see a couple new warnings which I am working on getting addressed. Just as a note, the warning coming from Azure.Core is because of a warning suppression that is missing so as long as it's just that one you're seeing then the code is still safe for trimming. On the KeyVault side, this is coming from a trimming update in .NET 8 that is different from .NET 8 RC2. I don't think the code is actually trim-incompatible here either, I need to confirm but I think this will also just be a suppression as well.