Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[System.ClientModel] Improve type of Credential property in ClientConnection struct #48296

Open
ShivangiReja opened this issue Feb 13, 2025 · 0 comments
Open

[System.ClientModel] Improve type of Credential property in ClientConnection struct #48296

ShivangiReja opened this issue Feb 13, 2025 · 0 comments
Labels
Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library

Comments

@ShivangiReja
Copy link
Member

The Credential property in the ClientConnection struct is currently typed as object. To improve type safety and reduce the need for downcasting in client creation, it would be better to define a type to represent credentials.

Reference - ClientConnection
@ShivangiReja ShivangiReja added Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library labels Feb 13, 2025
@ShivangiReja ShivangiReja mentioned this issue Feb 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShivangiReja