Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md needs more information on how to run tests #2109

Open
gearama opened this issue Feb 12, 2025 · 4 comments
Open

CONTRIBUTING.md needs more information on how to run tests #2109

gearama opened this issue Feb 12, 2025 · 4 comments
Labels
Milestone

Comments

@gearama
Copy link
Member

gearama commented Feb 12, 2025

I ran cargo test on a clean clone after cargo build

 Running tests\consumer.rs (target\debug\deps\consumer-943bfee5a1400f15.exe)

running 7 tests
test receive_lots_of_events ... FAILED
test test_get_properties ... FAILED
test test_new ... FAILED
test test_new_with_error ... FAILED
test test_get_partition_properties ... FAILED
test test_close ... FAILED
test test_open ... FAILED

I know the section says needs work but we really should have instructions on how to run tests if they require extra setup, also the base unit tests should maybe run the first time at least without failures.

Either specify what the tests require before testing or not have them run, or run a setup portion to get everything in order.

As a customer, seeing this from a basic clone and test seems off-putting

Got the same results when running Test-Pacjkages.ps1 from the eng folder

@github-project-automation github-project-automation bot moved this to Untriaged in Azure SDK Rust Feb 12, 2025
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 12, 2025
@hallipr
Copy link
Member

hallipr commented Feb 12, 2025

When I run cargo test from repo root in a fresh clone, most tests pass. Event Hubs appears to skip tests when prereqs aren't available while Key Vault tests fail for missing test-proxy.

@heaths
Copy link
Member

heaths commented Feb 14, 2025

We'll acquire test-proxy automatically with #1955. It's lower on the priority list, though. @LarryOsterman why are Event Hubs tests failing by default? They don't even use test-proxy nor should they be running unless @gearama has AZURE_TEST_MODE set at her machine (or parent process, otherwise) scope.

@RickWinter RickWinter changed the title Needs test info CONTRIBUTING.md needs more information on how to run tests Feb 14, 2025
@RickWinter RickWinter added Docs and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 14, 2025
@RickWinter RickWinter added this to the 2025-05 milestone Feb 14, 2025
@LarryOsterman
Copy link
Member

Eventhubs test should pass (or be skipped) if AZURE_TEST_MODE isn't set, or if it's set to anything other than "live".

They do when I run them locally (modulo doctest failures that are related to local changes).

My strong guess is that AZURE_TEST_MODE was set in George's environment.

@LarryOsterman
Copy link
Member

Confirmed with @gearama that AZURE_TEST_MODE was set in his environment, which explains the failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Untriaged
Development

No branches or pull requests

5 participants