Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Public IP Address has optional parameters that seem to be required #4254

Open
1 task done
kevin-381ecc2e opened this issue Jan 20, 2025 · 4 comments
Open
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@kevin-381ecc2e
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/network/public-ip-address

(Optional) Module Version

0.7.1

Description

It seems that within the Module for the Public Ip Address there is a false positive.

When using the module the documentation mentions that ddosSettings is 'Optional'.
Image

However when using the module and not providing it it results in an error that the ddosSetting is not present.
Image

When placing a blank 'ddosSetting' property the validator complains that it has missing properties.
Image

(Optional) Correlation Id

No response

@kevin-381ecc2e kevin-381ecc2e added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 20, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Jan 20, 2025
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Jan 20, 2025
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Jan 20, 2025
Copy link

@kevin-381ecc2e, thanks for submitting this issue for the avm/res/network/public-ip-address module!

Important

A member of the @Azure/avm-res-network-publicipaddress-module-owners-bicep or @Azure/avm-res-network-publicipaddress-module-contributors-bicep team will review it soon!

@ChrisSidebotham
Copy link
Contributor

Hi @kevin-381ecc2e.

Are you sure your not passing this with empty param. The last time this module published the tests ran and the results are here: https://github.com/Azure/bicep-registry-modules/actions/runs/12813357049/job/35728188982

In which the default test runs with only these inputs:

module testDeployment '../../../main.bicep' = [
for iteration in ['init', 'idem']: {
scope: resourceGroup
name: '${uniqueString(deployment().name, resourceLocation)}-test-${serviceShort}-${iteration}'
params: {
name: '${namePrefix}${serviceShort}001'
location: resourceLocation
}

@ChrisSidebotham ChrisSidebotham added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Triage 🔍 Maintainers need to triage still labels Jan 21, 2025
@ChrisSidebotham ChrisSidebotham moved this from Needs: Triage to Needs: Author Feedback in AVM - Module Issues Jan 21, 2025
@kevin-381ecc2e
Copy link
Author

When i don't provide the parameter it complains that its not present. And when i do provide an empty parameter it complains that protectionMode is missing

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Jan 23, 2025
@ChrisSidebotham
Copy link
Contributor

@kevin-381ecc2e - what bicep version are you using?

@description('Optional. The DDoS protection plan configuration associated with the public IP address.')
param ddosSettings ddosSettingsType?#

The input is nullable. it will only require protectionmode if the param is supplied

@ChrisSidebotham ChrisSidebotham added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Status: Needs: Author Feedback
Development

No branches or pull requests

2 participants