Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: Static Web App missing publicNetworkAccess parameter due to outdated API #4283

Open
1 task done
JarroVGIT opened this issue Jan 24, 2025 · 4 comments · May be fixed by #4286
Open
1 task done

[AVM Module Issue]: Static Web App missing publicNetworkAccess parameter due to outdated API #4283

JarroVGIT opened this issue Jan 24, 2025 · 4 comments · May be fixed by #4286
Assignees
@ChrisSidebotham
Labels
Class: Resource Module 📦 This is a resource module Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@JarroVGIT
Copy link

JarroVGIT commented Jan 24, 2025 •
edited
Loading

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Security Bug

Module Name

avm/res/web/static-site

(Optional) Module Version

No response

Description

Due to the usage of an old API (2021-03-01), this module is lacking the ability to disable public access to the Static WebApp.

This parameter is available in any of the next versions, such as 2022-03-01.

Is it possible to update the API used?

(Optional) Correlation Id

No response
@JarroVGIT JarroVGIT added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 24, 2025
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Jan 24, 2025
@avm-team-linter AVM Team Linter
Copy link

@JarroVGIT, thanks for submitting this issue for the avm/res/web/static-site module!

Important

A member of the @Azure/avm-res-web-staticsite-module-owners-bicep or @Azure/avm-res-web-staticsite-module-contributors-bicep team will review it soon!

@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Jan 24, 2025
ChrisSidebotham added a commit to ChrisSidebotham/bicep-registry-modules that referenced this issue Jan 24, 2025
@ChrisSidebotham
Changes to support [AVM Module Issue]: Static Web App missing `public…
f7ebd4f 
…NetworkAccess` parameter due to outdated API Azure#4283
@ChrisSidebotham ChrisSidebotham linked a pull request Jan 24, 2025 that will close this issue
Open
11 tasks
@ChrisSidebotham ChrisSidebotham added Type: Feature Request ➕ New feature or request Status: In PR 👉 This is when an issue is due to be fixed in an open PR and removed Needs: Triage 🔍 Maintainers need to triage still Type: Security Bug 🔒 This is a security bug labels Jan 27, 2025
@ChrisSidebotham
Copy link
Contributor

@JarroVGIT - This in in PR now, and will be available as soon as it is published to the MCR

@JarroVGIT
Copy link
Author

Thanks for the swift turn around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisSidebotham ChrisSidebotham

Labels
Class: Resource Module 📦 This is a resource module Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
AVM - Module Issues
Status: Needs: Triage
Milestone
No milestone
2 participants
@JarroVGIT @ChrisSidebotham