Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Private endpoint not being created in correct resource group in the latest sql server module 0.12.1 #4366

Closed
1 task done
corey-at-digizoo opened this issue Feb 3, 2025 · 7 comments · Fixed by #4421
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@corey-at-digizoo
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/sql/server

(Optional) Module Version

0.12.1

Description

I'm upgrading from using avm/res/sql/server version 0.8.0 -> 0.12.1 and I have noticed that the private endpoint is not being created in the correct resource group as defined by either the resourceGroupResourceId parameter, or in the case this parameter is not provided, the resource group which contains the virtual network subnet linked to that private endpoint.

From a code perspective it's most likely related to scope defined on the private endpoint sub module but I can't determine why it's not creating the private endpoint in the desired resource group.
I have tried:
a) Specifying resourceGroupResourceId parameter
b) Not specifying resourceGroupResourceId parameter, in which case it should be created in the resource group of the linked subnet

In either case, the private endpoint is being created in the same resource group as the sql server.

Kind regards,
Corey

(Optional) Correlation Id

No response

@corey-at-digizoo corey-at-digizoo added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 3, 2025

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Feb 3, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Feb 3, 2025
Copy link

@corey-at-digizoo, thanks for submitting this issue for the avm/res/sql/server module!

Important

A member of the @Azure/avm-res-sql-server-module-owners-bicep or @Azure/avm-res-sql-server-module-contributors-bicep team will review it soon!

@peterbud
Copy link
Contributor

peterbud commented Feb 3, 2025

Seems similar to #4257? PEP deployment is done using the common AVM module, I'll check it.

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Feb 7, 2025
@peterbud peterbud added Needs: Core Team 🧞 This item needs the AVM Core Team to review it Language: Bicep 💪 This is related to the Bicep IaC language and removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Feb 8, 2025
@peterbud
Copy link
Contributor

peterbud commented Feb 8, 2025

Confirmed the issue. PEP deployment is not respecting the specified resource group ID.

@corey-at-digizoo
Copy link
Author

Thanks @peterbud, yes it looks like the same issue as the the one you linked. Apologies, I did have a look through the open issues but I must have missed this one.

@peterbud
Copy link
Contributor

Thanks @peterbud, yes it looks like the same issue as the the one you linked. Apologies, I did have a look through the open issues but I must have missed this one.

Actually you helped a lot to realize that this is not an isolated problem, but something that is impacting multiple modules. PR is on it's way: #4421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
2 participants