Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] jammy: Use of multi-origin sources leaves some room for issues with source names #363

Open
cpuguy83 opened this issue Sep 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cpuguy83
Copy link
Member

cpuguy83 commented Sep 3, 2024

Currently jammy uses multi-origin sources when building the deb packages.
For reference: multi-origin is the practice of splitting sources into separate tarballs and creating an empty "orig" tarball (see the deb packaging layout for more details here).

Multi-orig tarballs have stricter naming requirements and as such we've had to sanitize source names which will probably work most of the time, but really the sanitization we have is bug-prone.
e.g., a source named foobar and foo-bar will almost certainly collide when building a deb package with dalec b/c the sanitization we did just strips forbidden characters.

I suggest we switch this strategy to just merge all the sources into one tarball with the desired layout.

@cpuguy83 cpuguy83 added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant