Replies: 1 comment
-
For anyone reading this, following my suggested approach of renaming would make things much clearer and the right condition would hence become: condition: and(not(failed()), not(canceled()), or(eq(dependencies.PlanStage.outputs['PlanJob.Plan.deployPolicyChanges'], 'yes'), eq(dependencies.PlanStage.outputs['PlanJob.Plan.deployRoleChanges'], 'yes'))) Tested and verified to be working :-) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
This is nothing that needs to be prioritized but would be nice to rename some of the things in the pipelines to make them easier to follow along.
In for example the following pipeline: epac-dev-pipeline.yml,
That makes up for the second stage having a condition set as:
condition: and(not(failed()), not(canceled()), or(eq(dependencies.Plan.outputs['Plan.Plan.deployPolicyChanges'], 'yes'), eq(dependencies.Plan.outputs['Plan.Plan.deployRoleChanges'], 'yes')))
It is somewhat hard to follow, which of the names are coming from the stage vs job vs step.
A better option would be to for instance rename:
And the condition can then become more meaningful in terms of the consumers of epac immediately understanding how the condition is supposed to be constructed in case we want to rename our stages and jobs to meet our needs.
Beta Was this translation helpful? Give feedback.
All reactions