Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing circular references #274

Open
alexandreczg opened this issue Jul 7, 2023 · 3 comments
Open

Allowing circular references #274

alexandreczg opened this issue Jul 7, 2023 · 3 comments

Comments

@alexandreczg
Copy link

Is there a way to generate the report allowing for circular dependencies on the parameters?

OpenApiDiffErrorImpl [VError]: ReferenceError: Circular $ref pointer found at /builds/#/components/schemas/Content/properties/children/items
    at /usr/local/lib/node_modules/openapi-diff/dist/openapi-diff/spec-differ/diff-finder/json-schema-diff.js:27:15
    at Generator.throw (<anonymous>)
    at rejected (/usr/local/lib/node_modules/openapi-diff/dist/openapi-diff/spec-differ/diff-finder/json-schema-diff.js:6:65) {
  jse_shortmsg: 'ReferenceError: Circular $ref pointer found at /builds/#/components/schemas/Content/properties/children/items',
  jse_info: {},
  code: 'OPENAPI_DIFF_DIFF_ERROR'
}

Thank you!

@afonsojramos
Copy link
Contributor

@mikeharder is this planned in any way? I can try and give a hand here.

@mikeharder
Copy link
Member

@afonsojramos: If you submit a pull request (with unit tests), we will review it, and likely merge it, if it solves a real problem with no downside.

@afonsojramos
Copy link
Contributor

@mikeharder Sounds good, any guiding advice as to where to look? Have opened a few PRs btw 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants