Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Spinner dismissing for challenge handling #156

Open
jasoncoolmax opened this issue Jun 19, 2018 · 0 comments
Open

Improve Spinner dismissing for challenge handling #156

jasoncoolmax opened this issue Jun 19, 2018 · 0 comments

Comments

@jasoncoolmax
Copy link
Member

Currently for embedded webview, we dismiss the loading spinner in the following delegate callback:

  • webView:didFinishNavigation:
  • webView:didFailNavigation:withError:
  • webView:didFailProvisionalNavigation:withError:

However, depending on server behavior, a page may or may not continue to load if we reject a auth challenge, say client TLS challenge.
If a page continues to load, the spinner will be dismissed by hitting any of the above delegate callbacks;
If a page does not continue to load, the spinner will not be dismissed.

We could try to figure out whether there is a way to improve the experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant