Fadi/maven central, Fixes AB#3395409 #2413
Open
+37
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the dependency on Maven Central by replacing it with an internal Azure DevOps Maven feed (NewAndroid). The changes consolidate repository configuration to use a single private feed for dependencies previously sourced from Maven Central.
Key changes:
- Replaced
mavenCentral()with private Azure DevOps Maven feed in both buildscript and project repositories - Updated repository comments to reflect the removal of Maven Central references
- Updated submodule reference
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| settings.gradle | Removed mavenCentral() from plugin management and updated comment |
| build.gradle | Replaced Maven Central with Azure DevOps NewAndroid feed in both buildscript and allprojects blocks, consolidated duplicate repository configurations |
| common | Updated submodule commit reference |
|
✅ Work item link check complete. Description contains link AB#3395409 to an Azure Boards work item. |
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received an s360 item asking our libraries to always pull packages from feeds, and not declare mavenCentral as a repository to source dependencies. The feed itself has maven as an upstream. We cannot use AndroidADAL feed as that one has some versions deleted (once a version is deleted from a feed, it cannot be restored, even if an upstream has it). Created a new feed to support this https://identitydivision.visualstudio.com/Engineering/_artifacts/feed/NewAndroid. We pull packages from this new feed, but we still publish our versions to AndroidADAL. The new feed has AndroidADAL as an upstream still.
AB#3395409