MSI POP Attestation #5612
Open
MSI POP Attestation #5612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
reviewed
Dec 8, 2025
| } | ||
| } | ||
| } | ||
| // This file intentionally left empty. |
Contributor
There was a problem hiding this comment.
can we delete this project? do we need this?
| @@ -0,0 +1,44 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
Contributor
There was a problem hiding this comment.
should we update the name to Microsoft.Identity.Client.Attestation or Microsoft.Identity.Client.KeyAttestation
| CsrMetadata csrMetadata = await GetCsrMetadataAsync(_requestContext).ConfigureAwait(false); | ||
|
|
||
| // Validate that mTLS PoP requires KeyGuard - fail fast before network calls | ||
| if (_isMtlsPopRequested) |
Contributor
There was a problem hiding this comment.
Wrong condition. Your comment is very clear,
- Attempt attestation only for KeyGuard keys when provider is available
- For non-KeyGuard keys (Hardware, InMemory), proceed with non-attested flow
| if (provider == null) | ||
| { | ||
| _requestContext.Logger.Info("[ImdsV2] No attestation provider configured. Proceeding with non-attested flow."); | ||
| return string.Empty; // Empty attestation token indicates non-attested flow |
Contributor
There was a problem hiding this comment.
Will MIRP accept an empty attestation string? has this been tested?
|
|
||
| // CreateManagedIdentityAsync does a probe; Add one more CSR response for the actual acquire. | ||
| httpManager.AddMockHandler(MockHelpers.MockCsrResponse()); | ||
| // Add mocks for successful non-attested flow (CSR + issuecredential + token) |
Contributor
There was a problem hiding this comment.
don't we need to update existing POP tests to use WithAttestationSupport()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #5591