correct ID token lookup logic when reading from cache #7702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the obo client, when fetching the idTokens from cache, the fetched Map value was incorrectly being assessed with Object.entries() instead of Map.entries(). This would cause the function to always return null.
ngomezdev
requested review from
a team,
hectormmg,
peterzenz,
sameerag and
tnorling
as code owners
Contributor
|
Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft. |
microsoft-github-policy-service
bot
added
the
Needs: Attention 👋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
msal-node/OnBehalfOfClient, the client is incorrectly checking/validating the idTokens returned from cache.It was assessing the
idTokenMapvalue usingObject.values(), which would always return[]. This would result in the client failing to retrieve the idToken from cache.This PR is changing that logic to use the appropriate
Map.values()function.