Skip to content

[Bug] Clone of DownstreamAPI options doesn't create deep clone of reference types #236

@keegan-caruso

Description

@keegan-caruso

Which version of Microsoft Identity Abstractions for dotnet are you using?
Note that to get help, you need to run the latest version.

Latest.

Repro

DownstreamApiOptions.Clone()

Expected behavior

Clone should create new reference types so that modifications are isolated. e.g. The Dictionary types.

Actual behavior

The reference to the dictionaries is only copied.

Possible solution

Create a new dictionary in the clone method.

Note, this also applies to the dictionaries on token acquisition options

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions