Form doesn't gracefully handle when there are more trainer cards in a deck than rows

[generalraikou]

Hi,
I'm unsure what one does on the official form when you have more trainers than rows on the form, but it doesn't look like this code gracefully handles this issue. Please see attached screenshot. Also, below is the exported decklist from LIVE, so you can try to recreate the issue:

Pokémon: 10
1 Eiscue BRS 44
1 Meloetta FST 124
1 Mew VMAX LOR-TG 30
2 Genesect V FST 185
1 Genesect V FST 255
2 Mew VMAX FST 114
1 Mew V FST 250
3 Mew V FST 113
1 Drapion V LOR 182
1 Genesect V FST 254

Trainer: 23
1 Iono PAL 254
1 Switch CRZ 144
1 Escape Rope BST 125
1 Forest Seal Stone SIT 156
1 Choice Belt ASR 211
2 Feather Ball ASR 141
1 Pal Pad SVI 182
2 Lost Vacuum LOR 162
1 Lost City LOR 161
3 Cram-o-matic FST 229
4 Battle VIP Pass FST 225
2 Nest Ball SVI 255
2 Path to the Peak CRE 148
3 Ultra Ball BRS 150
1 Cyllene ASR 201
3 Power Tablet FST 236
3 Elesa's Sparkle FST 233
1 Iono PAL 185 PH
1 Power Tablet FST 281
1 Judge FST 235
1 Avery CRE 187
1 Collapsed Stadium LOR 215
2 Boss's Orders BRS 132

Energy: 2
4 Fusion Strike Energy FST 244
3 Double Turbo Energy BRS 151

Total Cards: 60

[generalraikou]

So it looks like the code atleast checks for 60 cards, otherwise it'll print nothing on the form...but look at this one. if I remove one of the Iono rows, and then rewrite the last trainer card as just "Collapsed Stadium" and make sure my deck adds up to 60, it still overprints the rows, but the last row is blank. Without looking at the code, this may be a separate issue altogether.

Decklist:
Pokémon: 10
1 Eiscue BRS 44
1 Meloetta FST 124
1 Mew VMAX LOR-TG 30
2 Genesect V FST 185
1 Genesect V FST 255
2 Mew VMAX FST 114
1 Mew V FST 250
3 Mew V FST 113
1 Drapion V LOR 182
1 Genesect V FST 254

Trainer: 23
2 Iono PAL 254
1 Switch CRZ 144
1 Escape Rope BST 125
1 Forest Seal Stone SIT 156
1 Choice Belt ASR 211
2 Feather Ball ASR 141
1 Pal Pad SVI 182
2 Lost Vacuum LOR 162
1 Lost City LOR 161
3 Cram-o-matic FST 229
4 Battle VIP Pass FST 225
2 Nest Ball SVI 255
2 Path to the Peak CRE 148
3 Ultra Ball BRS 150
1 Cyllene ASR 201
3 Power Tablet FST 236
3 Elesa's Sparkle FST 233
1 Power Tablet FST 281
1 Judge FST 235
1 Avery CRE 187
3 Collapsed Stadium

Energy: 2
4 Fusion Strike Energy FST 244
3 Double Turbo Energy BRS 151

Total Cards: 60

Screenshot:

[Bratah123]

it still overprints the rows, but the last row is blank.

Hmm thanks for the issue posts! It seems this one could be it's own issue post, if you'd like to migrate it to another post.

[Bratah123]

Form doesn't gracefully handle when there are more trainer cards in a deck than rows

Regarding this issue, it is a known issue, but we are still deciding what the solution could be. We have a couple of ideas, but streamlining them and seeing how easy/hard it is to implement will take time for now thanks!

[generalraikou]

Form doesn't gracefully handle when there are more trainer cards in a deck than rows

Regarding this issue, it is a known issue, but we are still deciding what the solution could be. We have a couple of ideas, but streamlining them and seeing how easy/hard it is to implement will take time for now thanks!

NP. I get that we all have day jobs, lol.

I came across this tool while looking for a way to automatically fill out these for a league challenge and this is definitely really good. I don't do code on a daily basis anymore, but I've done enough use case testing that I can usually find bugs or user enhancements at least, lol.

[Bratah123]

For anyone still following this issue, this is the proposed solution me and @KOOKIIEStudios have mostly come up with

It just copies over another trainer row onto the right side allowing for another 18 rows (so still capped at 36) there isn't another graceful way that I can think of as of now for when trainers exceed 36. This solution is applicable for any of the other rows to double the amount of rows.

[Bratah123]

For anyone still following this issue, this is the proposed solution me and @KOOKIIEStudios have mostly come up with

It just copies over another trainer row onto the right side allowing for another 18 rows (so still capped at 36) there isn't another graceful way that I can think of as of now for when trainers exceed 36. This solution is applicable for any of the other rows to double the amount of rows.

Full Example

[KOOKIIEStudios]

Alternative is to make a page 2 with PTO notice on first page