Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality of displacement sensor should go to some other class #101

Open
srosenbu opened this issue May 3, 2023 · 1 comment
Open
Labels
enhancement New feature or request sensor Related to the sensors

Comments

@srosenbu
Copy link
Member

srosenbu commented May 3, 2023

Currently, the displacement sensor
https://github.com/BAMresearch/FenicsXConcrete/blob/main/src/fenicsxconcrete/sensor_definition/displacement_sensor.py
contains code that can evaluate a dolfinx.fem.Function object at any point. This functionality is needed in basically most sensors that access a Function, therefore I would put it into some other class, like PointSensor to avoid duplicate code

@srosenbu srosenbu added enhancement New feature or request sensor Related to the sensors labels May 3, 2023
@srosenbu
Copy link
Member Author

srosenbu commented May 3, 2023

Also, computing the colliding cells is done in each call of measure. I don't know how fast this method is, but to me it seems like something that should belong in the __init__

@eriktamsen eriktamsen removed their assignment May 3, 2023
@srosenbu srosenbu added this to the Hackathon 2024 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sensor Related to the sensors
Projects
None yet
Development

No branches or pull requests

2 participants