Problem when reading a vocabulary_type

[carlosmada22]

When reading this vocabulary file:

Vocabulary_Laser_Type.xlsx

This error arises:

bam_masterdata checker --file-path .\bam_masterdata\checker\tmp\Vocabulary_Laser_Type.xlsx --mode
 incoming
2025-11-03T17:29:51.114688Z [info     ] Loading current data model from: C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\bam_masterdata\datamodel
2025-11-03T17:29:53.263394Z [info     ] Loading new entities from: .\bam_masterdata\checker\tmp\Vocabulary_Laser_Type.xlsx
2025-11-03T17:29:53.264405Z [info     ] Source type: excel            
2025-11-03T17:29:53.273004Z [info     ] Validation rules successfully loaded.
2025-11-03T17:29:53.274043Z [error    ] Url template not found in the headers. term=Url template
2025-11-03T17:29:53.275309Z [warning  ] Url template not found in the properties headers. term=Url template
2025-11-03T17:29:53.275309Z [warning  ] Official not found in the properties headers. term=Official
Traceback (most recent call last):
  File "C:\Users\cmadaria\Miniconda3\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\cmadaria\Miniconda3\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\Scripts\bam_masterdata.exe\__main__.py", line 7, in <module>
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\click\core.py", line 1442, in __call__
    return self.main(*args, **kwargs)
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\click\core.py", line 1363, in main
    rv = self.invoke(ctx)
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\click\core.py", line 1830, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\click\core.py", line 1226, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\click\core.py", line 794, in invoke
    return callback(*args, **kwargs)
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\bam_masterdata\cli\cli.py", line 471, in checker
    run_checker(file_path=file_path, mode=mode, datamodel_path=datamodel_path)
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\bam_masterdata\cli\cli.py", line 385, in run_checker
    checker.load_new_entities(source=file_path)
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\bam_masterdata\checker\checker.py", line 36, in load_new_entities
    self.new_entities = loader.load()
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\bam_masterdata\checker\source_loader.py", line 45, in load
    return self.entities_to_json()
  File "C:\Users\cmadaria\Documents\Projects\BAMresearch\bam-masterdata\.venv\lib\site-packages\bam_masterdata\checker\source_loader.py", line 156, in entities_to_json
    transformed_entity["terms"].append(transformed_term)
KeyError: 'terms'

Which solution I couldn't find and solve.

[JosePizarro3]

Seeing the error, it seems a dictionary which was not initialize before to contain "terms", which happens when wanting to append. The solution should be to initialize this where (didnt check the code) the dictionary transformed_entity is defined, i.e.,

transformed_entity = {
    ...
    "terms": [],
}

I can take care of it if you don't have time.

[carlosmada22]

Seeing the error, it seems a dictionary which was not initialize before to contain "terms", which happens when wanting to append. The solution should be to initialize this where (didnt check the code) the dictionary transformed_entity is defined, i.e.,

transformed_entity = {
...
"terms": [],
}
I can take care of it if you don't have time.

Already tried that yesterday but couldn't make it work either, together with other fixes, maybe I was missing something. I will try to fix it again today and leave it a comment if not solved.