Promote team membership check to approve PR builds (GoogleCloudPlatform#13825)

ScottSuarez · melinath · BBBmau · commit dc84fc290d13 · 2025-05-20T10:51:06.000-07:00
Co-authored-by: Stephen Lewis (Burrows) &lt;stephen.r.burrows@gmail.com&gt;
diff --git a/.ci/magician/github/membership.go b/.ci/magician/github/membership.go
@@ -51,9 +51,10 @@ func (gh *Client) GetUserType(user string) UserType {
 	}
 
 	if gh.IsTeamMember("GoogleCloudPlatform", "terraform", user) {
-		fmt.Printf("Debug test --- User '%s' is an active member of the 'terraform' team in 'GoogleCloudPlatform' organization\n", user)
+		fmt.Println("User is an active member of the 'terraform' team in 'GoogleCloudPlatform' organization")
+		return GooglerUserType
 	} else {
-		fmt.Printf("Debug test --- User '%s' is not an active member of the 'terraform' team in 'GoogleCloudPlatform' organization\n", user)
+		fmt.Printf("User '%s' is not an active member of the 'terraform' team in 'GoogleCloudPlatform' organization\n", user)
 	}
 
 	if gh.IsOrgMember(user, "GoogleCloudPlatform") {

Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,10 @@ func (gh *Client) GetUserType(user string) UserType {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`if gh.IsTeamMember("GoogleCloudPlatform", "terraform", user) {`
`54`		`- fmt.Printf("Debug test --- User '%s' is an active member of the 'terraform' team in 'GoogleCloudPlatform' organization\n", user)`
	`54`	`+ fmt.Println("User is an active member of the 'terraform' team in 'GoogleCloudPlatform' organization")`
	`55`	`+ return GooglerUserType`
`55`	`56`	`} else {`
`56`		`- fmt.Printf("Debug test --- User '%s' is not an active member of the 'terraform' team in 'GoogleCloudPlatform' organization\n", user)`
	`57`	`+ fmt.Printf("User '%s' is not an active member of the 'terraform' team in 'GoogleCloudPlatform' organization\n", user)`
`57`	`58`	`}`
`58`	`59`
`59`	`60`	`if gh.IsOrgMember(user, "GoogleCloudPlatform") {`