Skip to content

Actor Update Bug #3

@beardyFace

Description

@beardyFace

Should the actor update not utilise idx[0] and idx[1] for Q1 and Q2? currently it just gets the same value of Q from the same critic

---------------------------- update actor ----------------------------

    if step == self.G-1:

        actions_pred, log_prob, _ = self.actor_local.sample(states)             
        
        # TODO: make this variable for possible more than two critics
        Q1 = self.critics[idx[**0**]](states, actions_pred.squeeze(0)).cpu()
        Q2 = self.critics[idx[**0**]](states, actions_pred.squeeze(0)).cpu()
        Q = torch.min(Q1,Q2)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions