From 6718f5091cd24bfbb7d8fdb4d4ab4cbd19ba4a12 Mon Sep 17 00:00:00 2001
From: Lou Huang <lou@streetmix.net>
Date: Tue, 3 Dec 2024 09:45:59 -0500
Subject: [PATCH 1/2] refactor(Layout): remove unused variable

---
 lib/ui/partials/Layout.js | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/ui/partials/Layout.js b/lib/ui/partials/Layout.js
index ec70d84a..54e4258f 100644
--- a/lib/ui/partials/Layout.js
+++ b/lib/ui/partials/Layout.js
@@ -142,9 +142,6 @@ class Layout extends Component {
     const controls = {
       toggleModal: this.toggleMobileMenu
     };
-    const conditions = {
-      hasMobileMenu
-    };
 
     return (
       <SharedHexContext.Provider

From cbb1f72398ea0193682983afbf3d565954ca5c1a Mon Sep 17 00:00:00 2001
From: Lou Huang <lou@streetmix.net>
Date: Tue, 3 Dec 2024 09:46:15 -0500
Subject: [PATCH 2/2] refactor(404): add title to iframe + refactor component

- resolve a warning that iframe is missing title attribute
- remove deprecated scrolling and frameborder attributes, use css instead
- refactor component to react function component
- keep the background music on this page even though it will never play unless
  you knew it was there and specifically allowed this site to play bg music
---
 src/pages/404.js | 41 ++++++++++++++++++++++-------------------
 1 file changed, 22 insertions(+), 19 deletions(-)

diff --git a/src/pages/404.js b/src/pages/404.js
index db76061f..9ffde8e0 100644
--- a/src/pages/404.js
+++ b/src/pages/404.js
@@ -1,24 +1,27 @@
-import React, { Component, Fragment } from "react";
+import React from "react";
+import styled from "styled-components";
 
 import { Helmet, Layout } from "ui/partials";
 
-export default class ErrorPage extends Component {
-  constructor(props) {
-    super(props);
-    this.state = {};
-  }
+const Iframe = styled.iframe`
+  overflow: hidden;
+  border: 0;
+`;
 
-  render() {
-    return (
-      <Fragment>
-        <Helmet {...this.props} title="Error" />
-        <Layout {...this.props}>
-          <h1>You'd think there would be something more interesting here.</h1>
-          <iframe width="1" height="1" scrolling="no" frameborder="no" allow="autoplay" src="https://w.soundcloud.com/player/?url=https%3A//api.soundcloud.com/tracks/348238181&color=%23ff5500&auto_play=true&hide_related=false&show_comments=true&show_user=true&show_reposts=false&show_teaser=true&visual=true"></iframe>
-        </Layout>
-      </Fragment>
-    );
-  }
+export default function ErrorPage(props) {
+  return (
+    <>
+      <Helmet {...props} title="Error" />
+      <Layout {...props}>
+        <h1>You'd think there would be something more interesting here.</h1>
+        <Iframe
+          title="Background music"
+          width="1"
+          height="1"
+          allow="autoplay"
+          src="https://w.soundcloud.com/player/?url=https%3A//api.soundcloud.com/tracks/348238181&color=%23ff5500&auto_play=true&hide_related=false&show_comments=true&show_user=true&show_reposts=false&show_teaser=true&visual=true"
+        />
+      </Layout>
+    </>
+  );
 }
-
-ErrorPage.propTypes = {};