You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Ran into a strange issue today when testing i18n changes in French. Might be related to #73.
The issue is that calendarCheckDate is erroneously creating a valid moment in some non-English locales (at least when using the default date format of MMMM D, YYYY). In my case, that meant all my preset dates were turning into Jan 20th. Seems like it could be a bug in moment (didn't see any after a cursory check).
Can the preset click handler just directly create moments instead of calling calendarCheckDate? Seems like the presets will always produce ISO 8601 date strings. This seemed to have fixed it in my fork.
Thanks.
The text was updated successfully, but these errors were encountered:
Thanks for bringing up the issue. I'll have to take a better look once I get some time but it looks like ensuring those dates are moment dates could potentially solve the problem.
Ran into a strange issue today when testing i18n changes in French. Might be related to #73.
The issue is that
calendarCheckDate
is erroneously creating a valid moment in some non-English locales (at least when using the default date format ofMMMM D, YYYY
). In my case, that meant all my preset dates were turning into Jan 20th. Seems like it could be a bug in moment (didn't see any after a cursory check).Here are some examples (using moment) of the behavior I'm seeing.
Can the preset click handler just directly create moments instead of calling
calendarCheckDate
? Seems like the presets will always produce ISO 8601 date strings. This seemed to have fixed it in my fork.Thanks.
The text was updated successfully, but these errors were encountered: