add Appgroupname api and uniqueness app group name (#234)

* add app group name api

* add uniqueness appgroup name validation

* update the commented spec

Author: fadlinurhasan

app/controllers/api/v2/infrastructures_controller.rb

@@ -56,6 +56,37 @@ def profile_by_cluster_name
     }
   end
 
+
+  def profile_by_app_group_name
+    @app_group = AppGroup.find_by(
+      name: params[:app_group_name],
+    )
+
+    if @app_group.blank? || !@app_group.available?
+      render(json: {
+               success: false,
+               errors: ['App Group not found'],
+               code: 404,
+             }, status: :not_found) && return
+    end
+
+    @helm_infrastructure = @app_group.helm_infrastructure
+
+    render json: {
+      app_group_name: @app_group.name,
+      app_group_secret: @app_group.secret_key,
+      capacity: @helm_infrastructure.helm_cluster_template.name,
+      cluster_name: @helm_infrastructure.cluster_name,
+      kibana_address: @helm_infrastructure&.kibana_address,
+      status: @helm_infrastructure.status,
+      provisioning_status: @helm_infrastructure.provisioning_status,
+      updated_at: @helm_infrastructure.updated_at.strftime(Figaro.env.timestamp_format),
+      meta: {
+        service_names: @helm_infrastructure.default_service_names
+      },
+    }
+  end
+
   def profile_curator
     if Figaro.env.es_curator_client_key != params[:client_key]
       render(json: {

app/models/app_group.rb

@@ -1,5 +1,6 @@
 class AppGroup < ApplicationRecord
   validates :name, :secret_key, presence: true
+  validates :name, uniqueness: true
 
   has_many :barito_apps
   has_many :app_group_users

config/routes.rb

@@ -38,6 +38,9 @@
       get :profile_by_cluster_name,
         to: 'infrastructures#profile_by_cluster_name',
         defaults: { format: :json }
+      get :profile_by_app_group_name,
+        to: 'infrastructures#profile_by_app_group_name',
+        defaults: { format: :json }
       get :profile_index,
         to: 'infrastructures#profile_index',
         defaults: { format: :json }

db/migrate/20211115000000_add_index_to_app_groups.rb

@@ -0,0 +1,5 @@
+class AddIndexToAppGroups < ActiveRecord::Migration[5.2]
+  def change
+    add_index :app_groups, :name
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2021_07_23_011211) do
+ActiveRecord::Schema.define(version: 2021_11_15_000000) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -60,6 +60,7 @@
     t.string "secret_key"
     t.integer "log_retention_days", default: 30
     t.string "environment", default: "PRODUCTION"
+    t.index ["name"], name: "index_app_groups_on_name"
     t.index ["secret_key"], name: "index_app_groups_on_secret_key"
   end
 
@@ -83,7 +84,7 @@
 
   create_table "cluster_templates", force: :cascade do |t|
     t.string "name"
-    t.jsonb "instances"
+    t.jsonb "manifest"
     t.jsonb "options"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
@@ -120,6 +121,12 @@
     t.index ["name"], name: "index_ext_apps_on_name", unique: true
   end
 
+  create_table "group_roles", force: :cascade do |t|
+    t.string "name", null: false
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+
   create_table "group_users", force: :cascade do |t|
     t.bigint "group_id"
     t.bigint "user_id"
@@ -188,7 +195,7 @@
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
     t.integer "cluster_template_id"
-    t.jsonb "instances", default: {}, null: false
+    t.jsonb "manifest", default: {}, null: false
     t.jsonb "options", default: {}, null: false
     t.jsonb "manifests", default: {}, null: false
     t.index ["app_group_id"], name: "index_infrastructures_on_app_group_id"

spec/models/app_group_spec.rb

@@ -1,6 +1,24 @@
 require 'rails_helper'
 
 RSpec.describe AppGroup, type: :model do
+  context 'uniqueness validation' do
+    describe ':name' do
+      subject { create(:app_group) }
+
+      it { is_expected.to validate_uniqueness_of(:name) }
+    end
+  end
+
+  context 'presence validation' do
+    it 'should check presence of name' do
+      expect(build(:app_group, name: nil)).not_to be_valid
+    end
+
+    it 'should check presence of secret_key' do
+      expect(build(:app_group, secret_key: nil)).not_to be_valid
+    end
+  end
+
   context 'Setup Application' do
     let(:app_group_props) { build(:app_group) }
     let(:helm_cluster_template) { create(:helm_cluster_template) }

spec/requests/api/v2/infrastructures_spec.rb

@@ -145,6 +145,72 @@
     end
   end
 
+  describe 'Profile by App Group Name API' do
+    let(:headers) do
+      { 'ACCEPT' => 'application/json', 'HTTP_ACCEPT' => 'application/json' }
+    end
+
+    it 'should return profile information of registered app when supplied cluster name' do
+      app_group = create(:app_group)
+      helm_infrastructure = create(
+        :helm_infrastructure,
+        app_group: app_group,
+        status: HelmInfrastructure.statuses[:active]
+      )
+
+      get api_v2_profile_by_app_group_name_path,
+        params: { access_token: @access_token, app_group_name: app_group.name },
+        headers: headers
+      json_response = JSON.parse(response.body)
+
+      %w[cluster_name status provisioning_status].
+        each do |key|
+          expect(json_response.key?(key)).to eq(true)
+          expect(json_response[key]).to eq(helm_infrastructure.send(key.to_sym))
+        end
+
+      expect(json_response['app_group_name']).to eq(helm_infrastructure.app_group_name)
+      expect(json_response['app_group_secret']).to eq(helm_infrastructure.app_group_secret)
+      expect(json_response['capacity']).to eq(helm_infrastructure.helm_cluster_template.name)
+      expect(json_response.key?('updated_at')).to eq(true)
+      expect(json_response['kibana_address']).to eq(helm_infrastructure.kibana_address)
+    end
+
+    it 'should return K8s Kibana if activated' do
+      app_group = create(:app_group)
+      helm_infrastructure = create(:helm_infrastructure,
+        app_group: app_group,
+        status: HelmInfrastructure.statuses[:active],
+        cluster_name: 'haza',
+      )
+
+      get api_v2_profile_by_app_group_name_path,
+        params: { access_token: @access_token, app_group_name: app_group.name },
+        headers: headers
+      json_response = JSON.parse(response.body)
+
+      expect(json_response['kibana_address']).to eq("#{helm_infrastructure.cluster_name}-kb-http.barito-worker.svc:5601")
+      expect(json_response['kibana_address']).to eq(helm_infrastructure.kibana_address)
+    end
+
+    context 'when App Group unavailable' do
+      it 'should return 404' do
+        error_msg = 'App Group not found'
+        app_group = create(:app_group)
+        helm_infrastructure = create(:helm_infrastructure, app_group: app_group)
+
+        get api_v2_profile_by_app_group_name_path,
+          params: { access_token: @access_token, app_group_name: app_group.name },
+          headers: headers
+        json_response = JSON.parse(response.body)
+
+        expect(json_response['success']).to eq false
+        expect(json_response['code']).to eq 404
+        expect(json_response['errors']).to eq [error_msg]
+      end
+    end
+  end
+
   describe 'Profile for Curator' do
     let(:headers) do
       { 'ACCEPT' => 'application/json', 'HTTP_ACCEPT' => 'application/json' }
@@ -213,8 +279,6 @@
         }
       ].to_json
     end
-
-
   end
 
   describe 'Profile for Prometheus Exporters' do