Skip to content

Commit 6f47511

Browse files
committed
Add handling for type parameters and override type in dictionary members
1 parent 2cea3f6 commit 6f47511

File tree

3 files changed

+11
-44
lines changed

3 files changed

+11
-44
lines changed

inputfiles/addedTypes.jsonc

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -790,50 +790,6 @@
790790
},
791791
"dictionaries": {
792792
"dictionary": {
793-
"ReadableStreamReadDoneResult": {
794-
"name": "ReadableStreamReadDoneResult",
795-
"typeParameters": [
796-
{
797-
"name": "T"
798-
}
799-
],
800-
"members": {
801-
"member": {
802-
"done": {
803-
"name": "done",
804-
"overrideType": "true",
805-
"required": true
806-
},
807-
"value": {
808-
"name": "value",
809-
"overrideType": "T | undefined",
810-
"required": true
811-
}
812-
}
813-
}
814-
},
815-
"ReadableStreamReadValueResult": {
816-
"name": "ReadableStreamReadValueResult",
817-
"typeParameters": [
818-
{
819-
"name": "T"
820-
}
821-
],
822-
"members": {
823-
"member": {
824-
"done": {
825-
"name": "done",
826-
"overrideType": "false",
827-
"required": true
828-
},
829-
"value": {
830-
"name": "value",
831-
"overrideType": "T",
832-
"required": true
833-
}
834-
}
835-
}
836-
},
837793
"UnderlyingByteSource": {
838794
"name": "UnderlyingByteSource",
839795
"members": {
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
dictionary ReadableStreamReadDoneResult typeParameters=T {
2+
member done type=boolean required=#true overrideType="true"
3+
member value required=#true overrideType="T | undefined"
4+
}
5+
6+
dictionary ReadableStreamReadValueResult typeParameters=T {
7+
member done required=#true overrideType="false"
8+
member value required=#true overrideType="T"
9+
}

src/build/patches.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,11 +318,13 @@ function handleDictionary(child: Node): DeepPartial<Dictionary> {
318318
return {
319319
name,
320320
members: { member },
321+
...handleTypeParameters(child.properties?.typeParameters),
321322
...optionalMember(
322323
"legacyNamespace",
323324
"string",
324325
child.properties?.legacyNamespace,
325326
),
327+
...optionalMember("overrideType", "string", child.properties?.overrideType)
326328
};
327329
}
328330

0 commit comments

Comments
 (0)