github: Switch to upload artifact v4 (#272)

* github: Switch to upload artifact v4

* github: Switch to macos13 runners

* cmake: Disable warn as error

Author: BastianBlokland

.github/workflows/build.yml

@@ -116,7 +116,7 @@ jobs:
             cxx: clang++-10
           }
         - {
-            image: macos-11,
+            image: macos-13,
             arch: x86_64,
             os: macos,
             compiler: appleclang,
@@ -185,7 +185,7 @@ jobs:
       run: pwsh .\scripts\test.ps1
 
     - name: archive
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: novus-release-${{matrix.config.image}}-${{matrix.config.arch}}-${{matrix.config.compiler}}
         path: bin

CMakeLists.txt

@@ -96,7 +96,7 @@ if(MSVC)
   set(CMAKE_EXE_LINKER_FLAGS "${LINKER_FLAGS_SHARED}")
 else()
   message(STATUS "Setting unix compiler flags")
-  set(CXX_FLAGS_SHARED "${CXX_FLAGS_SHARED} -std=c++17 -Werror -Wall -Wextra -fno-strict-aliasing")
+  set(CXX_FLAGS_SHARED "${CXX_FLAGS_SHARED} -std=c++17 -Wall -Wextra -fno-strict-aliasing")
   if(CMAKE_COMPILER_IS_GNUCXX OR MINGW)
     message(STATUS "Setting gcc specific compiler flags")
     # Disable 'maybe-uninitialized' warning on GCC, to many false positives at the time of writing.