Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransitUIWebViewContext must unbind from webview on dealloc #36

Open
HBehrens opened this issue Apr 8, 2014 · 0 comments
Open

TransitUIWebViewContext must unbind from webview on dealloc #36

HBehrens opened this issue Apr 8, 2014 · 0 comments

Comments

@HBehrens
Copy link
Member

HBehrens commented Apr 8, 2014

at TransitUIWebViewContext dealloc doesn't reset the original delegate to the webview. Something like this should be better:

-(void)dealloc {
    [self unbindFromWebView];
}

-(void)unbindFromWebView {
    [_webView removeObserver:self forKeyPath:@"delegate"];
    _webView.delegate = _originalDelegate;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant