Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageUpload component #237

Closed
wants to merge 3 commits into from
Closed

ImageUpload component #237

wants to merge 3 commits into from

Conversation

Rileran
Copy link
Contributor

@Rileran Rileran commented Jun 20, 2022 •
edited
Loading

Description

Adding a new component ImageUpload that let the user upload an image to cloudinary, display it, and remove it. This component also has its Field counterpart to integrate with Formiz.

Component

The component as an API similar to an input component, with chakra props support.

<ImageUpload value={imageUrl} onChange={setImageUrl} w="240px" />

image

The component also supports custom placeholder.

⚠️ Conflict with MirageJS

The image upload does not work properly with MirageJS, even when passthourgh is enabled. Right now, the upload of the image will work, but the function will get stuck in a pending state and won't return.

I am currently looking for a solution on the matter.

Related to issue #222

@Rileran Rileran linked an issue Jun 20, 2022 that may be closed by this pull request
ImageUpload component #222
Open
@vercel
Copy link

vercel bot commented Jun 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ❌ Failed (Inspect) Jun 9, 2023 1:41pm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Rileran Rileran marked this pull request as draft June 20, 2022 15:57
@DecampsRenan DecampsRenan force-pushed the feat/cloudinary-image-upload-component branch from 24470d9 to 5bca58d Compare December 23, 2022 09:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 23, 2022 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DecampsRenan
Copy link
Contributor

I think this code is a little bit outdated; maybe we can try to add a Formiz integration of react-uploady to handle those cases ?

There is a guide to do it with cloudinary: https://react-uploady.org/docs/guides/Cloudinary/

@DecampsRenan DecampsRenan force-pushed the feat/cloudinary-image-upload-component branch from 5bca58d to 534b8ec Compare June 9, 2023 13:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yoannfleurydev
Copy link
Member

Cloudinary is a bit overpriced, we decided not to go with it in the starter.

@yoannfleurydev yoannfleurydev deleted the feat/cloudinary-image-upload-component branch December 22, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImageUpload component
3 participants
@Rileran @DecampsRenan @yoannfleurydev