Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Automatic Cucumber tag update" not triggered for 2 years #260

Open
arnapou opened this issue Aug 30, 2024 · 3 comments
Open

"Automatic Cucumber tag update" not triggered for 2 years #260

arnapou opened this issue Aug 30, 2024 · 3 comments

Comments

@arnapou
Copy link

arnapou commented Aug 30, 2024

Context

  • I was looking at the composer.json file and saw a declared repository cucumber/cucumber
  • Because curiosity, I followed the link ... which redirected me to cucumber/common 🤔
  • Thus, I dove into the github actions .github/workflows/update.yaml + bin/update_cucumber.
    Apparently it creates Automatic Cucumber tag update to <TAG>.

Problem

When looking at the real cucumber/gherkin repo, I found that the last tag is 29.0 from 3 weeks ago.

But the composer.json is using the 24.0 from 2 years ago 😨.

There is probably something to watch & update there, isn't it ?

@stof
Copy link
Member

stof commented Aug 30, 2024

the workflow ran recently: https://github.com/Behat/Gherkin/actions/workflows/update.yml

However, it detected 24.1.0 as latest version apparently. The script probably need to be updated to account for the fact that cucumber has split gherkin from their previous monorepo again.

@arnapou
Copy link
Author

arnapou commented Aug 30, 2024

I have not the bandwidth to help (PR) etc ... at the moment.
At least, I wanted to raise the question.

Sorry for not being able to help more at the moment 🤗

@acoulton
Copy link
Contributor

I've started to work on this, also looking at #227 in parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants