Skip to content

Support ports with default values #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adivardi opened this issue Jan 15, 2025 · 0 comments
Open

Support ports with default values #57

adivardi opened this issue Jan 15, 2025 · 0 comments

Comments

@adivardi
Copy link

Is your feature request related to a problem? Please describe.
Currently, Groot cannot be used for nodes with default port values.
For such nodes, Groot will either:

  • Explicitly set the default value, if available in the models xml - OK, but requires propel models xml, and is tedious for repeated or complex types
  • Set the port value to "" - crashes for any non-string port

So after every save in Groot, we have to manually remove these ports.

Describe the solution you'd like
According to the tutorials, ports with default values should be omitted from the XML. I think either a solution can be either:

  • Groot can properly detects a port with default value and excludes it from the xml unless a value is given
  • A special string value indicating this port should be omitted (e.g. N/A)

Obviously, I think the first solution is nicer.

Describe alternatives you've considered
See above

Additional context

@adivardi adivardi changed the title Support default port values Support ports with default values Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant