Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop steps is not in meta schema #38

Closed
shanejonas opened this issue Mar 4, 2025 · 1 comment · Fixed by #39
Closed

Loop steps is not in meta schema #38

shanejonas opened this issue Mar 4, 2025 · 1 comment · Fixed by #39
Labels
released

Comments

@shanejonas
Copy link
Collaborator

It looks like a loop can have .steps but its not supported in the meta schema
shanejonas added a commit that referenced this issue Mar 4, 2025
@shanejonas
Add support for loop steps in meta schema
48e6dab 
Fixes #38

Add support for `.steps` property in loop steps in the meta schema.

* **meta-schema.json**
  - Add `steps` property to `LoopStep` definition.
  - Update `required` array to include `steps`.

* **src/__tests__/dependency-resolver.test.ts**
  - Add test case for loop step with `steps` property.

* **src/dependency-resolver.ts**
  - Update `findStepDependencies` method to handle `steps` property in loop steps.
  - Update `buildDependencyGraph` method to handle `steps` property in loop steps.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/BelfordZ/open-rpc-flow/issues/38?shareId=XXXX-XXXX-XXXX-XXXX).
@shanejonas shanejonas mentioned this issue Mar 4, 2025
Merged
shanejonas added a commit that referenced this issue Mar 4, 2025
@shanejonas
fix: add support for loop steps in meta schema
ce3f92c 
Fixes #38

Add support for `.steps` property in loop steps in the meta schema.

* **meta-schema.json**
  - Add `steps` property to `LoopStep` definition.
  - Update `required` array to include `steps`.

* **src/__tests__/dependency-resolver.test.ts**
  - Add test case for loop step with `steps` property.

* **src/dependency-resolver.ts**
  - Update `findStepDependencies` method to handle `steps` property in loop steps.
  - Update `buildDependencyGraph` method to handle `steps` property in loop steps.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/BelfordZ/open-rpc-flow/issues/38?shareId=XXXX-XXXX-XXXX-XXXX).
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

🎉 This issue has been resolved in version 1.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for loop steps in meta schema BelfordZ/open-rpc-flow
1 participant
@shanejonas