Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong foldangle in apply_folding_hinges_and_snaps() wiki example. #1307

Closed
mizahnyx opened this issue Nov 3, 2023 · 1 comment · Fixed by #1309
Closed

Wrong foldangle in apply_folding_hinges_and_snaps() wiki example. #1307

mizahnyx opened this issue Nov 3, 2023 · 1 comment · Fixed by #1309
Assignees

Comments

@mizahnyx
Copy link

mizahnyx commented Nov 3, 2023

In the hinges.scad wiki example for apply_folding_hinges_and_snaps(), the parameter foldangle is wrong, it should be 70.53 that is approximately the value of the dihedral angle of a tetrahedron. I verified it by generating and 3d printing the solid.

@adrianVmariano
Copy link
Collaborator

Yeah, this is right. The angle in there is the angle between an edge and a face. The correct angle is acos(1/3)

@adrianVmariano adrianVmariano linked a pull request Nov 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants