Skip to content

fix bspp size error #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianVmariano merged 3 commits into from
Jan 18, 2026
Merged

fix bspp size error #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79c9930
fix bspp size error
adrianVmariano Jan 17, 2026
ee6d7f3
commit right files
adrianVmariano Jan 17, 2026
a276c15
remove tabs
adrianVmariano Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions attachments.scad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,11 +1264,11 @@ module force_tag(tag)


// Module: default_tag()
// Synopsis: Sets a default tag for all children.
// Synopsis: Conditionally set a default tag for all children.
// Topics: Attachments
// See Also: force_tag(), recolor(), hide(), show_only(), diff(), intersect()
// Usage:
// PARENT() default_tag(tag) CHILDREN;
// PARENT() default_tag(tag, [do_tag]) CHILDREN;
// Description:
// Sets a default tag for all of the children. This is intended to be used to set a tag for a whole module
// that is then used outside the module, such as setting the tag to "remove" for easy operation with {{diff()}}.
Expand All @@ -1281,7 +1281,7 @@ module force_tag(tag)
// For a step-by-step explanation of tagged attachments, see the [Attachments Tutorial](Tutorial-Attachment-Tags).
// Arguments:
// tag = tag string, which must not contain any spaces.
// do_tag = if false do not set the tag.
// do_tag = if false do not set the tag. Default: true
// Side Effects:
// Sets `$tag` to the tag you specify, possibly with a scope prefix.
// Example(3D): The module thing() is defined with {{tag()}} and the user applied tag of "keep_it" is ignored, leaving the user puzzled.
Expand Down
32 changes: 17 additions & 15 deletions threading.scad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,26 +1100,28 @@ module npt_threaded_rod(
// cyl(d=3/4*INCH, l=42, $fn=32);
// }
// }

bspp_dimensions = [
// Size TPI OD
// Size TPI OD
[ 1/16, [ 28, 0.3041 ]],
[ 1/8, [ 28, 0.3372 ]],
[ 1/4, [ 19, 0.4506 ]],
[ 3/8, [ 19, 0.5886 ]],
[ 1/8, [ 28, 0.3830 ]],
[ 1/4, [ 19, 0.5180 ]],
[ 3/8, [ 19, 0.6560 ]],
[ 1/2, [ 14, 0.8250 ]],
[ 5/8, [ 14, 0.8105 ]],
[ 3/4, [ 14, 0.9495 ]],
[ 7/8, [ 14, 1.0975 ]],
[ 5/8, [ 14, 0.9020 ]],
[ 3/4, [ 14, 1.0410 ]],
[ 7/8, [ 14, 1.1890 ]],
[ 1, [ 11, 1.3090 ]],
[ 1+1/8, [ 11, 1.3756 ]],
[ 1+1/4, [ 11, 1.5335 ]],
[ 1+3/8, [ 11, 1.6285 ]],
[ 1+1/2, [ 11, 1.7656 ]],
[ 1+5/8, [ 11, 1.9656 ]],
[ 1+3/4, [ 11, 1.9995 ]],
[ 1+7/8, [ 11, 2.1276 ]],
[ 2, [ 11, 2.2306 ]],
[ 1+1/8, [ 11, 1.4920 ]],
[ 1+1/4, [ 11, 1.6500 ]],
[ 1+3/8, [ 11, 1.7450 ]],
[ 1+1/2, [ 11, 1.8820 ]],
[ 1+5/8, [ 11, 2.0820 ]],
[ 1+3/4, [ 11, 2.1160 ]],
[ 1+7/8, [ 11, 2.2440 ]],
[ 2, [ 11, 2.3470 ]],
];

function bspp_threaded_rod(
size,
left_handed=false, starts=1,
Expand Down