Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unknow-icon.gif missing with Django 1.9 #16

Open
bdesbiolles opened this issue Aug 24, 2016 · 1 comment · May be fixed by #17
Open

unknow-icon.gif missing with Django 1.9 #16

bdesbiolles opened this issue Aug 24, 2016 · 1 comment · May be fixed by #17

Comments

@bdesbiolles
Copy link

Hi,

with Django 1.9, some static images have changed like unknow-icon.gif which is know unknow-icon.svg. This causes graphical glitches (missing icon).

This image is used by super_inlines/templates/admin/edit_inline/tabular.html at line 19.

From where I stand I see two quick solutions:

  • change icon-unknown.gif to icon-unknown.svg and bump the version number (breaking compatibility).
  • add the image within the project static files to keep compatibility.

I can contribute to the project, I just wanted an opinion before submitting a PR directly.

Thanks,

Baptiste
@WhyNotHugo
Copy link

IMHO, it's best to update the reference and push the version. Copying files from django in order to support older, unsupported (by upstream) versions is too dirty.

@bdesbiolles bdesbiolles linked a pull request Aug 25, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated icon-unknown link for django 1.9 bdesbiolles/django-super-inlines
2 participants
@WhyNotHugo @bdesbiolles