add more tests for delete (go-xorm#22)

Author: lunny

builder_delete.go

@@ -5,13 +5,12 @@
 package builder
 
 import (
-	"errors"
 	"fmt"
 )
 
 func (b *Builder) deleteWriteTo(w Writer) error {
 	if len(b.tableName) <= 0 {
-		return errors.New("no table indicated")
+		return ErrNoTableName
 	}
 
 	if _, err := fmt.Fprintf(w, "DELETE FROM %s WHERE ", b.tableName); err != nil {

builder_delete_test.go

@@ -0,0 +1,24 @@
+// Copyright 2018 The Xorm Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package builder
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestBuilderDelete(t *testing.T) {
+	sql, args, err := Delete(Eq{"a": 1}).From("table1").ToSQL()
+	assert.NoError(t, err)
+	assert.EqualValues(t, "DELETE FROM table1 WHERE a=?", sql)
+	assert.EqualValues(t, []interface{}{1}, args)
+}
+
+func TestDeleteNoTable(t *testing.T) {
+	_, _, err := Delete(Eq{"b": "0"}).ToSQL()
+	assert.Error(t, err)
+	assert.EqualValues(t, ErrNoTableName, err)
+}

builder_test.go

@@ -432,12 +432,6 @@ func TestBuilderUpdate(t *testing.T) {
 	fmt.Println(sql, args)
 }
 
-func TestBuilderDelete(t *testing.T) {
-	sql, args, err := Delete(Eq{"a": 1}).From("table1").ToSQL()
-	assert.NoError(t, err)
-	fmt.Println(sql, args)
-}
-
 func TestSubquery(t *testing.T) {
 	subb := Select("id").From("table_b").Where(Eq{"b": "a"})
 	b := Select("a, b").From("table_a").Where(

error.go

@@ -15,4 +15,6 @@ var (
 	ErrNoInConditions = errors.New("No IN conditions")
 	// ErrNeedMoreArguments need more arguments
 	ErrNeedMoreArguments = errors.New("Need more sql arguments")
+	// ErrNoTableName no table name
+	ErrNoTableName = errors.New("No table indicated")
 )