-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it necessary to provide a React version for this library? #72
Comments
Hi there, I've never used Best, |
Hey @BigFatDog maybe not build a separate library but maybe add some examples using it with react? I personally am strugling to get it working properly. Do you have a snippet I could look? |
Yes, Please @BigFatDog |
@BigFatDog I am having trouble to work with parcoords-es in React! Please Help! |
@BigFatDog Yes, it will be useful for me! |
Would you please post your error messages here so that I can give it a try? I just tested
devDependencies:
Sample code:
|
I was actually not getting an error message, just the graph looked squished as if the height was 0. Your example made me realise I have to set the width/height on the container and it works, I had created a useD3 hook that abstracted that from me and I didn't realize. Also, I think you should select by the ref you created right? Otherwise it is kinda unnecessary, however it is the recommended way to access the DOM within react. Something like: Parcoords()(chartRef.current) Also I realize that the css is tied to the class That would make the selection the definite connection to the chart and avoid having a 'magic' class name that has to be included in the component. Thanks for the response, and a fully fledged component API still very welcome BTW! EDIT: Forgot to mention, I would love to help you with the React version, I don't yet have enough familiarity with the library to exactly say which should be the features or props relevant to such component but if you have any ideas I can try to put something together |
Yes. I just tested. I used id because I was not totally sure if the current parcoords would work with
I get your point. I need to have a closer look to make sure if it is possible to do this without providing a whole new react version of
It is about development time and library's quality:
Appreciate that! Honestly I tend to keep this library as it is so far. However, I'm open to small improvements that can help BTW, if I work on a data visualization library with React (irrelevant to |
This is practical. I'll do this. |
Oh yeah, I wouldn't think mixing a react version within this repo would be the way to go, more like a separate lib that is a wrapper to this one serving as a abstraction to the whole d3 backend, which many people (including myself) that work with React are not familiar with. |
Hello guys,
I'm wondering if it is necessary to build a
React
version of this library.Currently I'm using this library in
React
apps with React hooks.I feel it would be better if there were a
React
version, but only slightly better because I cannot see too much improvements there. I haven't found reason that firmly demands aReact
version so far.What do you think?
Yours
Yun Xing
The text was updated successfully, but these errors were encountered: