-
Notifications
You must be signed in to change notification settings - Fork 33
Description
Currently it is not possible to change axis stroke color through css.
In the parcoords.css such css property is set to a default, but it has no effect because these properties are set with d3s .style() function, having priority over css.
The values set through javascript are the same as the ones on the css sheet leading me to believe they are set as defaults.
Some of these properties are merely stylistic in nature, which could be useful if configurable (through css specialy), however some of them could be tied to the shape of the plot.
I could find some properties that could outsourced solely to the css sheet making them instantly configurable:
Stroke and Fill in: (maybe shape-rendering)
parcoords-es/src/api/createAxes.js
Lines 47 to 57 in dfd8d02
| axisElement | |
| .selectAll('path') | |
| .style('fill', 'none') | |
| .style('stroke', '#222') | |
| .style('shape-rendering', 'crispEdges'); | |
| axisElement | |
| .selectAll('line') | |
| .style('fill', 'none') | |
| .style('stroke', '#222') | |
| .style('shape-rendering', 'crispEdges'); |
parcoords-es/src/api/updateAxes.js
Lines 32 to 42 in dfd8d02
| axisElement | |
| .selectAll('path') | |
| .style('fill', 'none') | |
| .style('stroke', '#222') | |
| .style('shape-rendering', 'crispEdges'); | |
| axisElement | |
| .selectAll('line') | |
| .style('fill', 'none') | |
| .style('stroke', '#222') | |
| .style('shape-rendering', 'crispEdges'); |
Font in:
Lines 33 to 38 in dfd8d02
| pc.svg = selection | |
| .append('svg') | |
| .attr('width', config.width) | |
| .attr('height', config.height) | |
| .style('font', '14px sans-serif') | |
| .style('position', 'absolute') |