Skip to content

Commit d91bc35

Browse files
committed
add glam-31 feature
1 parent db32b54 commit d91bc35

File tree

4 files changed

+42
-3
lines changed

4 files changed

+42
-3
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
3939
- name: Check no_std build
4040
run: |
41-
cargo build --locked --no-default-features --features "libm, scheduled_events, musical_transport, all_nodes_no_std, pool"
41+
cargo build --locked --no-default-features --features "libm, scheduled_events, musical_transport, all_nodes_no_std, pool, glam-29, glam-30, glam-31"
4242
4343
# Check formatting.
4444
format:

Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,8 @@ wasm-bindgen = ["firewheel-cpal/wasm-bindgen"]
135135
glam-29 = ["firewheel-core/glam-29"]
136136
# Enables `glam::Vec2` and `glam::Vec3` parameter derives for glam 0.30.
137137
glam-30 = ["firewheel-core/glam-30"]
138+
# Enables `glam::Vec2` and `glam::Vec3` parameter derives for glam 0.31.
139+
glam-31 = ["firewheel-core/glam-31"]
138140
# Enables the `MIDI` event type, using the `wmidi` crate.
139141
midi_events = ["firewheel-core/midi_events"]
140142
# Enables serde derives for types

crates/firewheel-core/Cargo.toml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,22 @@ std = [
4646
"bevy_reflect?/std",
4747
"glam-29?/std",
4848
"glam-30?/std",
49+
"glam-31?/std",
4950
"portable-atomic/std",
5051
"num-traits/std",
5152
"thiserror/std",
5253
"thunderdome/std",
5354
"ringbuf/std",
5455
"wmidi?/std",
55-
"rtgc/std"
56+
"rtgc/std",
5657
]
5758
# Enable this if "std" is disabled.
58-
libm = ["num-traits/libm"]
59+
libm = [
60+
"num-traits/libm",
61+
"glam-29?/nostd-libm",
62+
"glam-30?/nostd-libm",
63+
"glam-31?/nostd-libm"
64+
]
5965
# Enables scheduling events for audio nodes.
6066
#
6167
# NOTE TO THIRD PARTY NODE DEVELOPERS: Please keep this feature disabled
@@ -84,6 +90,8 @@ bevy_reflect = ["dep:bevy_reflect"]
8490
glam-29 = ["dep:glam-29"]
8591
# Enables `glam::Vec2` and `glam::Vec3` parameter derives for glam 0.30.
8692
glam-30 = ["dep:glam-30"]
93+
# Enables `glam::Vec2` and `glam::Vec3` parameter derives for glam 0.31.
94+
glam-31 = ["dep:glam-31"]
8795
# Enables the `MIDI` event type, using the `wmidi` crate.
8896
midi_events = ["dep:wmidi"]
8997
# Enables serde derives for types
@@ -103,6 +111,7 @@ bevy_ecs = { workspace = true, optional = true }
103111
bevy_reflect = { workspace = true, optional = true }
104112
glam-29 = { package = "glam", version = "0.29", default-features = false, optional = true }
105113
glam-30 = { package = "glam", version = "0.30", default-features = false, optional = true }
114+
glam-31 = { package = "glam", version = "0.31", default-features = false, optional = true }
106115
# TODO: Remove this once `bevy_platform` exposes the atomic float types from `portable-atomic`.
107116
portable-atomic = { version = "1", default-features = false, features = [
108117
"fallback",

crates/firewheel-core/src/vector.rs

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,3 +138,31 @@ impl From<Vec3> for glam_30::Vec3 {
138138
Self::new(value.x, value.y, value.z)
139139
}
140140
}
141+
142+
#[cfg(feature = "glam-31")]
143+
impl From<glam_31::Vec2> for Vec2 {
144+
fn from(value: glam_31::Vec2) -> Self {
145+
Self::new(value.x, value.y)
146+
}
147+
}
148+
149+
#[cfg(feature = "glam-31")]
150+
impl From<glam_31::Vec3> for Vec3 {
151+
fn from(value: glam_31::Vec3) -> Self {
152+
Self::new(value.x, value.y, value.z)
153+
}
154+
}
155+
156+
#[cfg(feature = "glam-31")]
157+
impl From<Vec2> for glam_31::Vec2 {
158+
fn from(value: Vec2) -> Self {
159+
Self::new(value.x, value.y)
160+
}
161+
}
162+
163+
#[cfg(feature = "glam-31")]
164+
impl From<Vec3> for glam_31::Vec3 {
165+
fn from(value: Vec3) -> Self {
166+
Self::new(value.x, value.y, value.z)
167+
}
168+
}

0 commit comments

Comments
 (0)