Skip to content

Implement rotate_img() in SpatialExperiment class #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keviny2 opened this issue Apr 16, 2025 · 2 comments
Open

Implement rotate_img() in SpatialExperiment class #43

keviny2 opened this issue Apr 16, 2025 · 2 comments
Assignees

Comments

@keviny2
Copy link
Collaborator

keviny2 commented Apr 16, 2025

No description provided.

@keviny2 keviny2 self-assigned this Apr 16, 2025
@keviny2 keviny2 moved this to In progress in Support spatial modality Apr 16, 2025
@keviny2
Copy link
Collaborator Author

keviny2 commented Apr 16, 2025

when using rotate_img(), should spatial_coords also be updated? bioconductor does not update the coords https://github.com/drighelli/SpatialExperiment/blob/devel/R/imgData-methods.R#L235

the issue is:

  • if we update coords, not all images are necessarily rotated
  • if we don't update coords, rotated images will have mismatched coordinates

@jkanche what do you think?

@jkanche
Copy link
Member

jkanche commented Apr 17, 2025

I like to keep it simple, the user only intends to rotate the image :) So, we follow bioc's implementation. I believe this is also the same with squipy/spatialdata, rotating the image does not update coordinates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

2 participants