Added few strings+case insensitive feature #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Je ne suis pas sûr de l'intérêt du ".*" dans ces expressions régulières. Tu risques de ne remplacer que la première occurence dans un paragraphe/zone de texte. Attention aussi, tu as utilisé des quotes simples pour l'apostraphe. Il est possible qu'il soit utilisé de réelles apostrophes, auquel cas, la regex ne matchera plus. Et les Regexp sont en les flags "global" et "insensible à la case" (g et i), donc ça devrait déjà être case insensible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added few string such as "Le Chef de l'Etat", "le candidat d'En Marche" + made all strings case insensitive (because medias doesn't always write "République" or "Président" with a capital letter.)