Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Kirki Font Control for Headings uses incorrect property "variant" instead of "font-variant" #453

Closed
jessecowens opened this issue Jul 26, 2021 · 1 comment

Comments

@jessecowens
Copy link
Member

Describe the bug
Fonts that use a different weight than "400" for their bold variant do not adjust when their variant is chosen in the customizer. This is the style that is produced:

<style id="kirki-postmessage-bgtfw_headings_typography">h1, .h1, h2, .h2, h3, .h3, h4, .h4, h5, .h5, h6, .h6, .bgc-heading.bgc-page-title{font-family:Old Standard TT;}h1, .h1, h2, .h2, h3, .h3, h4, .h4, h5, .h5, h6, .h6, .bgc-heading.bgc-page-title{line-height:1.1;}h1, .h1, h2, .h2, h3, .h3, h4, .h4, h5, .h5, h6, .h6, .bgc-heading.bgc-page-title{text-transform:uppercase;}h1, .h1, h2, .h2, h3, .h3, h4, .h4, h5, .h5, h6, .h6, .bgc-heading.bgc-page-title{variant:700;}h1, .h1, h2, .h2, h3, .h3, h4, .h4, h5, .h5, h6, .h6, .bgc-heading.bgc-page-title{font-style:normal;}</style>

The variant:700 is not a valid CSS property, it should be font-variant:700

To Reproduce
Steps to reproduce the behavior:

  1. Go to Customize > Fonts.
  2. For the Headings, choose a Google Font that has a different variant weight, for example Old Standart TT
  3. Select 700
  4. Note that heading font weight does not change

Expected behavior
The inline CSS from Kirki should use font-variant to correctly adjust the weight of the font.

Screenshots
image

@nicolepaschen
Copy link
Member

Duplicate of #307

@nicolepaschen nicolepaschen marked this as a duplicate of #307 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants