Skip to content

Commit 087d318

Browse files
Reduced code footprint, updated docs
1 parent 55598bd commit 087d318

26 files changed

+27
-32
lines changed

src/main/java/swervelib/SwerveModule.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ public class SwerveModule {
4545
/** Encoder synchronization queued. */
4646
private boolean synchronizeEncoderQueued = false;
4747

48-
/** Absolute Encoder Read Issue Dectected. */
49-
public boolean absoluteEncoderReadIssue = false;
50-
5148
/**
5249
* Construct the swerve module and initialize the swerve module motors and absolute encoder.
5350
*
@@ -256,14 +253,11 @@ public SwerveModulePosition getPosition() {
256253
public double getAbsolutePosition() {
257254
double angle;
258255
if (absoluteEncoder != null) {
259-
absoluteEncoderReadIssue = false;
260256
angle = absoluteEncoder.getAbsolutePosition() - angleOffset;
261257
if (absoluteEncoder.readingError) {
262-
absoluteEncoderReadIssue = true;
263258
angle = getRelativePosition();
264259
}
265260
} else {
266-
absoluteEncoderReadIssue = true;
267261
angle = getRelativePosition();
268262
}
269263
angle %= 360;
@@ -340,12 +334,13 @@ public SwerveModuleConfiguration getConfiguration() {
340334
return configuration;
341335
}
342336

343-
/*
344-
* Get if the last Absolute Encoder had a read issue.
337+
/**
338+
* Get if the last Absolute Encoder had a read issue, such as it does not exist.
345339
*
346-
* @return If the last Absolute Encoder had a read issue.
340+
* @return If the last Absolute Encoder had a read issue, or absolute encoder does not exist.
347341
*/
348342
public boolean getAbsoluteEncoderReadIssue() {
349-
return absoluteEncoderReadIssue;
343+
if (absoluteEncoder == null) return true;
344+
else return absoluteEncoder.readingError;
350345
}
351346
}

yagsl/repos/swervelib/YAGSL-cpp/maven-metadata.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88
<versions>
99
<version>2023.1.6</version>
1010
</versions>
11-
<lastUpdated>20231129225827</lastUpdated>
11+
<lastUpdated>20231129233622</lastUpdated>
1212
</versioning>
1313
</metadata>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7b07e72d5ec6d34358857f96863a056d
1+
63a22b931b0c5a74161af5908fe9b005
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
a9e94492cdfd009f170d24e98375431f35055f68
1+
641871e7ebe0b9937e5be9b1740495818c341a97
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f1d4f66647ca83fccab78c37334b8657c69cf87d81c6275559c4888502586a63
1+
f7b2c29a274f489f713c90a671444d85d637f4f3acfb1f692515e4f5dda0bf31
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
952620311014b85c13cc8536499ca8995b369d81e70c9f2411af1a594215c971a0d3ceb0f715b225a12656dd405bbc76a750bb1d7057d030bccdf81204c359c5
1+
215e36f0073035fa7d9c8654491498451e50408a068db5562243e29414fb503c519db3d2b5fddab3a57ffa4d3404355bfa8ae60aff957820206dd1e766a0930f
Binary file not shown.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
a9b6e4ef2f13a3ffa5f538d8e7d2e86f
1+
27eeec8643556916a8330b31fe0af871
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
60f023ce7400505143f5672f13d08c1c8af4aad9
1+
830a43b1bade68378dedab8872f84dba0a5ab32d
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
650d2e09c41a3da692683851a46ee37aded93cf412517dce9eced23a75219207
1+
9cf86b2ae08e41c9bf5b06fdcd810f0c5f550e8608d0fcab20a3dd258a911463

0 commit comments

Comments
 (0)