increase strict TS compat

Author: forman

ISSUES.md

@@ -66,4 +66,9 @@
   * Replace `Object.assign({}, a, b, ...)` calls by `{...a, ...b, ...}`.
 
 - App logic:
+  * When authentication fails we always say "Wrong username or password", but reasons may be very different,
+    e.g. CORS stuff (TypeError), 40x and 50x errors
+  * Getting message "Opps! Connection ... closed" when logging out.
   * Electron main, remote mode: Only quit after we have successfully logged out OR after timeout
+  * When going back from first screen, `webAPIConfig` will be the one from CateHub. To fix this
+    we need `interface { local: WebAPIConfig, remote: WebAPIConfig }`

src/common/array-diff.ts

@@ -1,5 +1,5 @@
 import * as assert from './assert';
-import deepEqual = require('deep-equal');
+import deepEqual from 'deep-equal';
 
 type ObjectWithId = { id: any; }
 
@@ -49,9 +49,9 @@ export interface ArrayAction<T extends ObjectWithId> {
  *        Signature: (element1, element2) => any
  * @returns {ArrayAction<T>[]} An array of actions to be performed to make oldArray equal to newArray.
  */
-export function arrayDiff<T extends ObjectWithId>(oldArray: T[], newArray: T[], computeChange?): ArrayAction<T>[] {
+export function arrayDiff<T extends ObjectWithId>(oldArray: T[], newArray: T[], computeChange?: (e1: any, e2: any) => any): ArrayAction<T>[] {
 
-    const actions = <ArrayAction<T>[]>[];
+    const actions = [] as ArrayAction<T>[];
     const currentArray = oldArray.slice();
 
     // REMOVE first, so we have less actions afterwards

src/renderer/reducers.ts

@@ -54,7 +54,7 @@ import {
     INITIAL_SESSION_STATE
 } from './initial-state';
 import { NEW_CTX_OPERATION_STEP_DIALOG_ID } from './containers/operation-step-dialog-ids';
-import deepEqual = require('deep-equal');
+import deepEqual from 'deep-equal';
 
 // Note: reducers are unit-tested through actions.spec.ts