Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player: implement theme customizations #1953

Open
2 tasks done
zzacharo opened this issue Oct 8, 2024 · 0 comments · May be fixed by #1973
Open
2 tasks done

player: implement theme customizations #1953

zzacharo opened this issue Oct 8, 2024 · 0 comments · May be fixed by #1973

Comments

@zzacharo
Copy link
Contributor

zzacharo commented Oct 8, 2024

Information about the Issue

The "IR-ECO" team is preparing the launch of their new https://arts.cern/ website and they asked for some customization on the video player embedding so it matches with their overall design.

Specifically we would need to add:

  • One embedding parameter called skin=light where it would control the play button icon. The icon they provided is by the arts team and can be found here. The width would be needed to be 10% (provided is at 20%).
  • Add one explicit embedding parameter to hide the social share button on the player. At the moment this is hardcoded in the code and it should be moved to the embedded config as a parameter. The new parameter would be socialSharing={0,1} with default to enabled so we keep the current behaviour.

Skin parameter proposed solution

We can introduce a new skin parameter that conditionally adds a CSS class i.e. theme-light following the proposed customization from https://www.theoplayer.com/docs/theoplayer/how-to-guides/ui/how-to-change-big-play-button/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants